From: John Johansen <john.johansen@canonical.com>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org
Subject: Re: [PATCH 2/2] AppArmor: Fix masking of capabilities in complain mode
Date: Wed, 29 Jun 2011 08:55:18 +0100 [thread overview]
Message-ID: <4E0ADA66.9070004@canonical.com> (raw)
In-Reply-To: <20110629042440.GC18344@kroah.com>
On 06/29/2011 05:24 AM, Greg KH wrote:
> On Wed, Jun 29, 2011 at 02:44:34AM +0100, John Johansen wrote:
>> AppArmor is masking the capabilities returned by capget against the
>> capabilities mask in the profile. This is wrong, in complain mode the
>> profile has effectively all capabilities, as the profile restrictions are
>> not being enforced, merely tested against to determine if an access is
>> known by the profile.
>>
>> This can result in the wrong behavior of security conscience applications
>> like sshd which examine their capability set, and change their behavior
>> accordingly. In this case because of the masked capability set being
>> returned sshd fails due to DAC checks, even when the profile is in complain
>> mode.
>>
>> Kernels affected: 2.6.36 - 3.0.
>>
>> Signed-off-by: John Johansen <john.johansen@canonical.com>
>> ---
>
> You say that multiple kernels are affected, then why not also include
> stable@kernel.org here as well?
>
> confused,
>
Sorry I should have elaborated, I think its a borderline case for stable
release, and was as much a note to my self as anything.
The bug doesn't affect the enforcement of policy, only learning mode used
for generating policy, and it is something we can work around in userspace.
for already released kernels.
I can resend with a Cc: stable if you would like
next prev parent reply other threads:[~2011-06-29 7:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-29 1:44 [Patch v2 0/2] Fix for masking of complain mode, and rcu protected ref John Johansen
2011-06-29 1:44 ` [PATCH 1/2] AppArmor: Fix reference to rcu protected pointer outside of rcu_read_lock John Johansen
2011-06-29 1:44 ` [PATCH 2/2] AppArmor: Fix masking of capabilities in complain mode John Johansen
2011-06-29 4:24 ` Greg KH
2011-06-29 7:55 ` John Johansen [this message]
2011-06-29 15:05 ` Greg KH
2011-06-29 3:05 ` [Patch v2 0/2] Fix for masking of complain mode, and rcu protected ref James Morris
-- strict thread matches above, loose matches on Subject: below --
2011-06-28 15:56 [Patch 0/2] Fixes " John Johansen
2011-06-28 15:56 ` [PATCH 2/2] AppArmor: Fix masking of capabilities in complain mode John Johansen
2011-06-28 18:12 ` Greg KH
2011-06-28 23:19 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0ADA66.9070004@canonical.com \
--to=john.johansen@canonical.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox