Re: [PATCH V1] led: pm8xxx: Add pm8xxx leds driver

[Stephen Boyd <sboyd@codeaurora.org>]

On 06/22/2011 03:49 AM, Anirudh Ghayal wrote:
> +
> +/**
> + * struct pm8xxx_led_data - internal led data structure
> + * @led_classdev - led class device
> + * @id - led index
> + * @led_brightness - led brightness levels
> + * @work - workqueue for led
> + * @lock - to protect the transactions
> + * @reg - cached value of led register
> + */

This isn't kerneldoc notation.

> +fail_id_check:
> +	if (i > 0) {
> +		for (i = i - 1; i >= 0; i--) {
> +			int index = pdata->leds[i].flags;
> +			mutex_destroy(&led[index].lock);
> +			led_classdev_unregister(&led[index].cdev);
> +		}
> +	}

if (i > 0) is redundant here.

> +/**
> + * enum pm8xxx_leds - PMIC8XXX supported led ids
> + * @PM8XXX_ID_LED_KB_LIGHT - keyboard backlight led
> + * @PM8XXX_ID_LED_0 - First low current led
> + * @PM8XXX_ID_LED_1 - Second low current led
> + * @PM8XXX_ID_LED_2 - Third low current led
> + * @PM8XXX_ID_FLASH_LED_0 - First flash led
> + * @PM8XXX_ID_FLASH_LED_0 - Second flash led
> + */
> +

This isn't kerneldoc notation.

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.