From: Ulrich Drepper <drepper@akkadia.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: akpm@linux-foundation.org, kosaki.motohiro@jp.fujitsu.com,
linux-kernel@vger.kernel.org, rientjes@google.com,
viro@zeniv.linux.org.uk, wilsons@start.ca
Subject: Re: [PATCH] Add cloexec information to fdinfo
Date: Wed, 29 Jun 2011 22:59:53 -0400 [thread overview]
Message-ID: <4E0BE6A9.3040708@akkadia.org> (raw)
In-Reply-To: <BANLkTi=pUZnhBa9W0eobQ_RWQGtMZ3u6Eg@mail.gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 06/29/2011 02:05 PM, Linus Torvalds wrote:
> Ok, minimally tested now, it seems to work from the one trivial
> test-case I wrote for it.
>
> I'm not going to commit it, but if others think this is a reasonable
> thing to do and remind me during the next merge window, we can do it
> then.
It provides the information, yes, but it also hides some information.
If you do it this way we cannot distinguish code which uses O_CLOEXEC at
open-time from uses of fcntl(FD_CLOEXEC).
This is not needed for the specific application I have in mind. But if
you, for instance, want to track down code which uses fcntl instead of
doing the work at open-time using O_CLOEXEC we would need this information.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAk4L5qQACgkQ2ijCOnn/RHSplwCgrA7RXs9gI7sr4e7SuvYsI04b
dmEAnA9eD4k9ZdFoJuQvGoXkBkjolfZn
=6GVj
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2011-06-30 3:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-10 3:55 [PATCH] Add cloexec information to fdinfo drepper
2011-06-13 2:54 ` KOSAKI Motohiro
2011-06-20 21:31 ` Andrew Morton
2011-06-28 7:07 ` Ulrich Drepper
2011-06-28 17:23 ` Linus Torvalds
2011-06-29 8:15 ` Ulrich Drepper
2011-06-29 10:51 ` Pádraig Brady
2011-06-29 16:22 ` Linus Torvalds
2011-06-29 18:05 ` Linus Torvalds
2011-06-30 2:59 ` Ulrich Drepper [this message]
2011-06-30 13:39 ` Ulrich Drepper
2011-06-30 16:07 ` Linus Torvalds
2011-08-05 11:49 ` Ulrich Drepper
2011-08-06 18:58 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0BE6A9.3040708@akkadia.org \
--to=drepper@akkadia.org \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=wilsons@start.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox