From: Ulrich Drepper <drepper@akkadia.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: akpm@linux-foundation.org, kosaki.motohiro@jp.fujitsu.com,
linux-kernel@vger.kernel.org, rientjes@google.com,
viro@zeniv.linux.org.uk, wilsons@start.ca
Subject: Re: [PATCH] Add cloexec information to fdinfo
Date: Thu, 30 Jun 2011 09:39:33 -0400 [thread overview]
Message-ID: <4E0C7C95.4070803@akkadia.org> (raw)
In-Reply-To: <4E0BE6A9.3040708@akkadia.org>
[-- Attachment #1: Type: text/plain, Size: 622 bytes --]
On 06/29/2011 10:59 PM, Ulrich Drepper wrote:
> It provides the information, yes, but it also hides some information.
> If you do it this way we cannot distinguish code which uses O_CLOEXEC at
> open-time from uses of fcntl(FD_CLOEXEC).
One more reason to at least not use the patch as you have it right now.
If a file descriptor was opened with O_CLOEXEC but subsequently the bit
has been reset using fcntl() the f_flags value would still have the
O_CLOEXEC bit set.
If you don't like the separate cloexec line, at least reset the
O_CLOEXEC bit in the f_flags output if the FD_ISSET() test returns zero.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-06-30 13:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-10 3:55 [PATCH] Add cloexec information to fdinfo drepper
2011-06-13 2:54 ` KOSAKI Motohiro
2011-06-20 21:31 ` Andrew Morton
2011-06-28 7:07 ` Ulrich Drepper
2011-06-28 17:23 ` Linus Torvalds
2011-06-29 8:15 ` Ulrich Drepper
2011-06-29 10:51 ` Pádraig Brady
2011-06-29 16:22 ` Linus Torvalds
2011-06-29 18:05 ` Linus Torvalds
2011-06-30 2:59 ` Ulrich Drepper
2011-06-30 13:39 ` Ulrich Drepper [this message]
2011-06-30 16:07 ` Linus Torvalds
2011-08-05 11:49 ` Ulrich Drepper
2011-08-06 18:58 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0C7C95.4070803@akkadia.org \
--to=drepper@akkadia.org \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=wilsons@start.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox