From: Igor Grinberg <grinberg@compulab.co.il>
To: Stanislav Brabec <utx@penguin.cz>
Cc: Marek Vasut <marek.vasut@gmail.com>,
linux-arm-kernel@lists.infradead.org,
zaurus-devel@www.linuxtogo.org,
spi-devel-general@lists.sourceforge.net, vapier@gentoo.org,
khilman@deeprootsystems.com, dmitry.torokhov@gmail.com,
linux-kernel@vger.kernel.org, pavel@ucw.cz,
linux-input@vger.kernel.org, eric.y.miao@gmail.com,
akpm@linux-foundation.org, broonie@opensource.wolfsonmicro.com
Subject: Re: kernel panic in spi_complete() on spitz (PXA270)
Date: Thu, 30 Jun 2011 18:25:51 +0300 [thread overview]
Message-ID: <4E0C957F.8080807@compulab.co.il> (raw)
In-Reply-To: <1309445118.4406.47.camel@oct.suse.cz>
On 06/30/11 17:45, Stanislav Brabec wrote:
> Marek Vasut wrote:
>> On Thursday, June 23, 2011 06:09:40 PM Stanislav Brabec wrote:
>>> Hallo.
>>>
>>> These Oops and kernel panic were observed on a Zaurus (spitz) machine
>>> (ARMv5, PXA270).
>> Looks similar to "Re: [PATCH v2] Input: Make ADS7846 independent on regulator"
> I don't see any trace in that thread. But yes, I was testing your patch
> from this thread. Without it, ADS7846 does not work on spitz (ADS7846
> does not have any dedicated regulator there). I want to
> add .needs_regulator bool to ads7846.c and send the patch again to the
> list.
Please, don't...
I thought we've finished discussing the regulator issue...
Instead of patching the driver and the platform data and the board file,
you should do _either_ of the following:
1) add regulator definition for ads7846 into the board file
2) enable the CONFIG_REGULATOR_DUMMY in your kernel configuration
3) use regulator_use_dummy_regulator() call in the board file.
Using either of the above, you will not need the patch for ads7846, only for the board file.
--
Regards,
Igor.
next prev parent reply other threads:[~2011-06-30 15:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1308845380.4533.54.camel@oct.suse.cz>
2011-06-30 11:52 ` kernel panic in spi_complete() on spitz (PXA270) Marek Vasut
2011-06-30 14:45 ` Stanislav Brabec
2011-06-30 15:09 ` Marek Vasut
2011-06-30 15:36 ` Pavel Herrmann
2011-06-30 16:22 ` Stanislav Brabec
2011-06-30 15:25 ` Igor Grinberg [this message]
2011-06-30 15:59 ` Mark Brown
2011-06-30 16:13 ` Stanislav Brabec
2011-06-30 17:40 ` Igor Grinberg
2011-06-30 18:01 ` Mark Brown
2011-06-30 20:50 ` Igor Grinberg
2011-06-30 22:20 ` Stanislav Brabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0C957F.8080807@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=akpm@linux-foundation.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=eric.y.miao@gmail.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=pavel@ucw.cz \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=utx@penguin.cz \
--cc=vapier@gentoo.org \
--cc=zaurus-devel@www.linuxtogo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox