From: "H. Peter Anvin" <hpa@zytor.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Markus Trippelsdorf <markus@trippelsdorf.de>,
Michal Marek <mmarek@suse.cz>, Joe Perches <joe@perches.com>,
Nick Bowler <nbowler@elliptictech.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sam Ravnborg <sam@ravnborg.org>,
Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Subject: Re: {PATCH] fix __packed in exported kernel headers
Date: Thu, 30 Jun 2011 12:01:56 -0700 [thread overview]
Message-ID: <4E0CC824.40909@zytor.com> (raw)
In-Reply-To: <BANLkTimf=21wbscEZRtfm+XFue713w7ZNA@mail.gmail.com>
On 06/30/2011 11:58 AM, Mike Frysinger wrote:
> On Thu, Jun 30, 2011 at 14:52, H. Peter Anvin wrote:
>> On 06/30/2011 11:48 AM, Mike Frysinger wrote:
>>> without fallback logic (#ifndef xxx...#define xxx...#endif), i think
>>> that's throwing an unreasonable amount of requirements onto userspace
>>> consumers
>>
>> Unclear. Too much "smarts" in kernel headers is a constant headache to
>> userspace consumers.
>
> not even being able to include a header without hitting a build
> failure without first declaring some magic defines (which,
> realistically, the vast majority of people will be doing exactly the
> same as they'll be using gcc) is unreasonable. hence my suggestion
> about compiler.h.
>
Not unless the kernel uses its own namespace for these defines. The
thing is, most libraries have their own macro library for this, and
collisions are both likely and bad.
-hpa
next prev parent reply other threads:[~2011-06-30 19:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-22 6:34 __packed vs. __attribute__((packed)) in kernel headers Markus Trippelsdorf
2011-06-23 13:42 ` Nick Bowler
2011-06-23 15:02 ` Markus Trippelsdorf
2011-06-23 16:57 ` Joe Perches
2011-06-24 13:07 ` Michal Marek
2011-06-24 13:51 ` {PATCH] fix __packed in exported " Markus Trippelsdorf
2011-06-24 15:17 ` Michal Marek
2011-06-24 16:33 ` Arnd Bergmann
2011-06-24 17:00 ` Mike Frysinger
2011-06-30 18:26 ` H. Peter Anvin
2011-06-30 18:48 ` Mike Frysinger
2011-06-30 18:52 ` H. Peter Anvin
2011-06-30 18:58 ` Mike Frysinger
2011-06-30 19:01 ` H. Peter Anvin [this message]
2011-06-30 19:13 ` Mike Frysinger
2011-06-30 20:02 ` H. Peter Anvin
2011-06-30 21:56 ` Mike Frysinger
2011-06-24 17:01 ` Markus Trippelsdorf
2011-06-23 17:04 ` __packed vs. __attribute__((packed)) in " richard -rw- weinberger
2011-06-23 17:46 ` Markus Trippelsdorf
2011-06-23 17:54 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0CC824.40909@zytor.com \
--to=hpa@zytor.com \
--cc=Artem.Bityutskiy@nokia.com \
--cc=arnd@arndb.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@trippelsdorf.de \
--cc=mmarek@suse.cz \
--cc=nbowler@elliptictech.com \
--cc=sam@ravnborg.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox