Acer Aspire One now hangs on reboot/shutdown

Acer Aspire One now hangs on reboot/shutdown

[Peter Chubb]

Hi Matthew,
   GIT commit  660e34cebf0a11d54f2d5dd8838607452355f321 x86: reorder
   reboot method preferences causes my Acer Aspire One to hang on
   shutdown/reboot. 

   I'm running the original Aspire One A110, BIOS version 3310.

   Booting with reboot=k or reboot=b both work; so it looks like an
   ACPI firmware bug.

   I printed out the FADT bits that were relevant---it claims revision 4
   in the header, and the ACPI_FADT_RESET_REGISTER bit is set in the
   flags.  The values of the reset register's address and width look
   reasonable (address 3321 in IO space, width 8 offset 0)

   I'm not sure of the best fix:  one could I suppose add the Aspire
   One to the list of machines that need BIOS reboot.  Is there a
   cleaner fix?

Peter C
--
Dr Peter Chubb                                  peter DOT chubb AT nicta.com.au
http://www.ertos.nicta.com.au               ERTOS within National ICT Australia
All things shall perish from under the sky/Music alone shall live, never to die

Re: Acer Aspire One now hangs on reboot/shutdown

[Matthew Garrett]

On Wed, Jun 22, 2011 at 08:38:08PM +1000, Peter Chubb wrote:

>    I printed out the FADT bits that were relevant---it claims revision 4
>    in the header, and the ACPI_FADT_RESET_REGISTER bit is set in the
>    flags.  The values of the reset register's address and width look
>    reasonable (address 3321 in IO space, width 8 offset 0)

Irritating. Ok, let's see if we can figure this out. Can you put the 
system's acpidump output somewhere? Also, if you boot with 
init=/bin/bash, what does writing the FADT reset value to 3321 do?

-- 
Matthew Garrett | mjg59@srcf.ucam.org

Re: Acer Aspire One now hangs on reboot/shutdown

[Matthew Garrett]

On Wed, Jun 22, 2011 at 08:38:08PM +1000, Peter Chubb wrote:
> 
> Hi Matthew,
>    GIT commit  660e34cebf0a11d54f2d5dd8838607452355f321 x86: reorder
>    reboot method preferences causes my Acer Aspire One to hang on
>    shutdown/reboot. 

Also, shutdown? Really?

-- 
Matthew Garrett | mjg59@srcf.ucam.org

Re: Acer Aspire One now hangs on reboot/shutdown

[Peter Chubb]

>>>>> "Matthew" == Matthew Garrett <mjg59@srcf.ucam.org> writes:

Matthew> On Wed, Jun 22, 2011 at 08:38:08PM +1000, Peter Chubb wrote:
>> 
>> Hi Matthew, GIT commit 660e34cebf0a11d54f2d5dd8838607452355f321
>> x86: reorder reboot method preferences causes my Acer Aspire One to
>> hang on shutdown/reboot.

Matthew> Also, shutdown? Really?

Sorry, shutdown -r (which is reboot really).


Writing the reset value `6' to the reset port 3321 in single user mode
makes the screen go blank, and the machine to become totally
unresponsive.  The power light remains on.  But the machine does *not*
reboot.

I've put up the ACPI tables at
http://www.cse.unsw.edu.au/~peterc/AspireOneACPI

The relevant part of the FADT is:
[074h 0116 12]               Reset Register : <Generic Address Structure>
[074h 0116  1]                     Space ID : 01 (SystemIO)
[075h 0117  1]                    Bit Width : 08
[076h 0118  1]                   Bit Offset : 00
[077h 0119  1]                 Access Width : 01
[078h 0120  8]                      Address : 0000000000000CF9

[080h 0128  1]         Value to cause reset : 06


--
Dr Peter Chubb  http://www.gelato.unsw.edu.au  peterc AT gelato.unsw.edu.au
http://www.ertos.nicta.com.au           ERTOS within National ICT Australia

Re: Acer Aspire One now hangs on reboot/shutdown

[H. Peter Anvin]

On 06/22/2011 04:50 PM, Peter Chubb wrote:
>>>>>> "Matthew" == Matthew Garrett <mjg59@srcf.ucam.org> writes:
> 
> Matthew> On Wed, Jun 22, 2011 at 08:38:08PM +1000, Peter Chubb wrote:
>>>
>>> Hi Matthew, GIT commit 660e34cebf0a11d54f2d5dd8838607452355f321
>>> x86: reorder reboot method preferences causes my Acer Aspire One to
>>> hang on shutdown/reboot.
> 
> Matthew> Also, shutdown? Really?
> 
> Sorry, shutdown -r (which is reboot really).
> 
> 
> Writing the reset value `6' to the reset port 3321 in single user mode
> makes the screen go blank, and the machine to become totally
> unresponsive.  The power light remains on.  But the machine does *not*
> reboot.
> 
> I've put up the ACPI tables at
> http://www.cse.unsw.edu.au/~peterc/AspireOneACPI
> 
> The relevant part of the FADT is:
> [074h 0116 12]               Reset Register : <Generic Address Structure>
> [074h 0116  1]                     Space ID : 01 (SystemIO)
> [075h 0117  1]                    Bit Width : 08
> [076h 0118  1]                   Bit Offset : 00
> [077h 0119  1]                 Access Width : 01
> [078h 0120  8]                      Address : 0000000000000CF9
> 
> [080h 0128  1]         Value to cause reset : 06
> 

OK, so this machine is actively broken and needs a quirk.

Which "reboot=" options work on this machine?

	-hpa

Re: Acer Aspire One now hangs on reboot/shutdown

[Peter Chubb]

>>>>> "H" == H Peter Anvin <hpa@zytor.com> writes:

H> On 06/22/2011 04:50 PM, Peter Chubb wrote:
>>>>>>> "Matthew" == Matthew Garrett <mjg59@srcf.ucam.org> writes:
>> 
Matthew> On Wed, Jun 22, 2011 at 08:38:08PM +1000, Peter Chubb wrote:
>>>> 
>>>> Hi Matthew, GIT commit 660e34cebf0a11d54f2d5dd8838607452355f321
>>>> x86: reorder reboot method preferences causes my Acer Aspire One
>>>> to hang on shutdown/reboot.
>> 
Matthew> Also, shutdown? Really?
>> 
>> Sorry, shutdown -r (which is reboot really).
>> 
>> 
>> Writing the reset value `6' to the reset port 3321 in single user
>> mode makes the screen go blank, and the machine to become totally
>> unresponsive.  The power light remains on.  But the machine does
>> *not* reboot.
>> 
>> I've put up the ACPI tables at
>> http://www.cse.unsw.edu.au/~peterc/AspireOneACPI
>> 
>> The relevant part of the FADT is: [074h 0116 12] Reset Register :
>> <Generic Address Structure> [074h 0116 1] Space ID : 01 (SystemIO)
>> [075h 0117 1] Bit Width : 08 [076h 0118 1] Bit Offset : 00 [077h
>> 0119 1] Access Width : 01 [078h 0120 8] Address : 0000000000000CF9
>> 
>> [080h 0128 1] Value to cause reset : 06
>> 

H> OK, so this machine is actively broken and needs a quirk.

H> Which "reboot=" options work on this machine?

b and k

t, p and a all result in a machine hang with the power light on, the
backlight off, and no apparent activity anywhere.

H> 	-hpa

H> --
Dr Peter Chubb                                  peter DOT chubb AT nicta.com.au
http://www.ertos.nicta.com.au               ERTOS within National ICT Australia
All things shall perish from under the sky/Music alone shall live, never to die

Re: Acer Aspire One now hangs on reboot/shutdown

[Matthew Garrett]

On Fri, Jul 01, 2011 at 09:10:33AM +1000, Peter Chubb wrote:

> t, p and a all result in a machine hang with the power light on, the
> backlight off, and no apparent activity anywhere.

Having PCI reboot be broken does make me wonder whether there's 
something about the hardware state that confuses it.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

Re: Acer Aspire One now hangs on reboot/shutdown

[H. Peter Anvin]

On 06/30/2011 04:58 PM, Matthew Garrett wrote:
> On Fri, Jul 01, 2011 at 09:10:33AM +1000, Peter Chubb wrote:
> 
>> t, p and a all result in a machine hang with the power light on, the
>> backlight off, and no apparent activity anywhere.
> 
> Having PCI reboot be broken does make me wonder whether there's 
> something about the hardware state that confuses it.
> 

It might be a RESET versus INIT difference... if the "PCI reboot" (which
is what "ACPI reboot") points to, it might end up pulling INIT, whereas
the keyboard controller pulls RESET.

RESET would forcibly initialize the hardware state of the machine,
obviously...

	-hpa

Re: Acer Aspire One now hangs on reboot/shutdown

[Matthew Garrett]

On Thu, Jun 30, 2011 at 05:18:01PM -0700, H. Peter Anvin wrote:

> It might be a RESET versus INIT difference... if the "PCI reboot" (which
> is what "ACPI reboot") points to, it might end up pulling INIT, whereas
> the keyboard controller pulls RESET.
> 
> RESET would forcibly initialize the hardware state of the machine,
> obviously...

I guess I'm going to have to go back and retest the XP behaviour. I'd 
expect this machine to be using the ACPI vector there too.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

Re: Acer Aspire One now hangs on reboot/shutdown

[Peter Chubb]

>>>>> "Matthew" == Matthew Garrett <mjg59@srcf.ucam.org> writes:

 Matthew> On Thu, Jun 30, 2011 at 05:18:01PM -0700, H. Peter Anvin
 Matthew> wrote:
 >> It might be a RESET versus INIT difference... if the "PCI reboot"
 >> (which is what "ACPI reboot") points to, it might end up pulling
 >> INIT, whereas the keyboard controller pulls RESET.
 >> 
 >> RESET would forcibly initialize the hardware state of the machine,
 >> obviously...

 Matthew> I guess I'm going to have to go back and retest the XP
 Matthew> behaviour. I'd expect this machine to be using the ACPI
 Matthew> vector there too.

This machine was only ever shipped with Linux (Linpus) on it, AFAIK.

Peter C
--
Dr Peter Chubb  http://www.gelato.unsw.edu.au  peterc AT gelato.unsw.edu.au
http://www.ertos.nicta.com.au           ERTOS within National ICT Australia

Re: Acer Aspire One now hangs on reboot/shutdown

[H. Peter Anvin]

On 06/30/2011 05:31 PM, Peter Chubb wrote:
> 
>  Matthew> I guess I'm going to have to go back and retest the XP
>  Matthew> behaviour. I'd expect this machine to be using the ACPI
>  Matthew> vector there too.
> 
> This machine was only ever shipped with Linux (Linpus) on it, AFAIK.
> 

OK, so the old Linux behavior was the only that ever got exercised.
That makes sense.

	-hpa

Re: Acer Aspire One now hangs on reboot/shutdown

[Matthew Garrett]

On Fri, Jul 01, 2011 at 10:31:53AM +1000, Peter Chubb wrote:
>  Matthew> I guess I'm going to have to go back and retest the XP
>  Matthew> behaviour. I'd expect this machine to be using the ACPI
>  Matthew> vector there too.
> 
> This machine was only ever shipped with Linux (Linpus) on it, AFAIK.

Ha! Ok, let me look into this some more.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

Re: Acer Aspire One now hangs on reboot/shutdown

[Matthew Garrett]

On Fri, Jul 01, 2011 at 10:31:53AM +1000, Peter Chubb wrote:

> This machine was only ever shipped with Linux (Linpus) on it, AFAIK.

Bother. Your ACPI tables still make an _OSI query for Windows, even if 
it only ever booted Linux - but only if there's no _OSI Linux. So we 
could theoretically quirk it based on an OSI call for Linux followed by 
one for Windows (rather than the other way around), but I suspect that 
this is a specific enough case that a static quirk may be the easiest 
thing to do here.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

Re: Acer Aspire One now hangs on reboot/shutdown

[Peter Chubb]

Since git commit 
  660e34cebf0a11d54f2d5dd8838607452355f321 x86: reorder reboot method
  preferences, 
my Acer Aspire One hangs on reboot.  It appears that its ACPI method
for rebooting is broken.  The attached patch adds a quirk so that the
machine will reboot via the BIOS.

Signed-off-by: Peter Chubb <peter.chubb@nicta.com.au>

Index: linux-2.6/arch/x86/kernel/reboot.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/reboot.c	2011-07-06 10:30:00.273792656 +1000
+++ linux-2.6/arch/x86/kernel/reboot.c	2011-07-06 10:39:53.397925146 +1000
@@ -294,6 +294,14 @@
 			DMI_MATCH(DMI_BOARD_NAME, "VersaLogic Menlow board"),
 		},
 	},
+	{ /* Handle reboot issue on Acer Aspire one */
+		.callback = set_bios_reboot,
+		.ident = "Acer Aspire One A110",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "AOA110"),
+		},
+	},
 	{ }
 };
 


--
Dr Peter Chubb                                  peter DOT chubb AT nicta.com.au
http://www.ertos.nicta.com.au               ERTOS within National ICT Australia
All things shall perish from under the sky/Music alone shall live, never to die

[tip:x86/urgent] x86, reboot: Acer Aspire One A110 reboot quirk

[tip-bot for Peter Chubb]

Commit-ID:  b49c78d4827be8d7e67e5b94adac6b30a4a9ad14
Gitweb:     http://git.kernel.org/tip/b49c78d4827be8d7e67e5b94adac6b30a4a9ad14
Author:     Peter Chubb <peter.chubb@nicta.com.au>
AuthorDate: Wed, 6 Jul 2011 10:56:30 +1000
Committer:  H. Peter Anvin <hpa@zytor.com>
CommitDate: Tue, 5 Jul 2011 19:43:23 -0700

x86, reboot: Acer Aspire One A110 reboot quirk

Since git commit
  660e34cebf0a11d54f2d5dd8838607452355f321 x86: reorder reboot method
  preferences,
my Acer Aspire One hangs on reboot.  It appears that its ACPI method
for rebooting is broken.  The attached patch adds a quirk so that the
machine will reboot via the BIOS.

[ hpa: verified that the ACPI control on this machine is just plain broken. ]

Signed-off-by: Peter Chubb <peter.chubb@nicta.com.au>
Link: http://lkml.kernel.org/r/w439iki5vl.wl%25peter@chubb.wattle.id.au
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
---
 arch/x86/kernel/reboot.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
index 0c016f7..4f0d46f 100644
--- a/arch/x86/kernel/reboot.c
+++ b/arch/x86/kernel/reboot.c
@@ -294,6 +294,14 @@ static struct dmi_system_id __initdata reboot_dmi_table[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "VersaLogic Menlow board"),
 		},
 	},
+	{ /* Handle reboot issue on Acer Aspire one */
+		.callback = set_bios_reboot,
+		.ident = "Acer Aspire One A110",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "AOA110"),
+		},
+	},
 	{ }
 };