From: "H. Peter Anvin" <hpa@linux.intel.com>
To: Brian Gerst <brgerst@gmail.com>
Cc: Greg Dietsche <greg@farmergreg.com>,
"H. Peter Anvin" <hpa@zytor.com>,
mingo@redhat.com, linux-kernel@vger.kernel.org,
Gregory.Dietsche@cuw.edu, tglx@linutronix.de,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/cleanups] x86, smpboot: Mark names[] array as const
Date: Thu, 30 Jun 2011 18:21:59 -0700 [thread overview]
Message-ID: <4E0D2137.3000001@linux.intel.com> (raw)
In-Reply-To: <BANLkTimO30XXhzQt15tDK1-+ch8GcH4bjw@mail.gmail.com>
On 06/30/2011 06:20 PM, Brian Gerst wrote:
> On Thu, Jun 30, 2011 at 8:47 PM, H. Peter Anvin <hpa@linux.intel.com> wrote:
>> On 06/30/2011 05:41 PM, Greg Dietsche wrote:
>>> On Thu, Jun 30, 2011 at 05:25:36PM -0700, H. Peter Anvin wrote:
>>>> On 06/30/2011 05:21 PM, tip-bot for Greg Dietsche wrote:
>>>>> + const char const *names[] = { "ID", "VERSION", "SPIV" };
>>>> ^^^^^^^^^^^^^^^^
>>>>
>>>> Doesn't make sense, patch removed...
>>>>
>>> could you explain a little more? I don't see my mistake.
>>> it compiles and is running on my box currently.
>>>
>
> One const is for the strings, the other is for the array of pointers.
>
Yes, the syntax is wrong for that.
const char * const names[] is I think what he wanted.
-hpa
prev parent reply other threads:[~2011-07-01 1:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1309473108-5337-1-git-send-email-Gregory.Dietsche@cuw.edu>
2011-07-01 0:21 ` [tip:x86/cleanups] x86, smpboot: Mark names[] array as const tip-bot for Greg Dietsche
2011-07-01 0:25 ` H. Peter Anvin
2011-07-01 0:41 ` Greg Dietsche
2011-07-01 0:47 ` H. Peter Anvin
2011-07-01 1:20 ` Brian Gerst
2011-07-01 1:21 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0D2137.3000001@linux.intel.com \
--to=hpa@linux.intel.com \
--cc=Gregory.Dietsche@cuw.edu \
--cc=brgerst@gmail.com \
--cc=greg@farmergreg.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox