From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752977Ab1GDBay (ORCPT ); Sun, 3 Jul 2011 21:30:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3291 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752588Ab1GDBax (ORCPT ); Sun, 3 Jul 2011 21:30:53 -0400 Message-ID: <4E1117C0.4020500@redhat.com> Date: Mon, 04 Jul 2011 09:30:40 +0800 From: Cong Wang User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc14 Thunderbird/3.1.10 MIME-Version: 1.0 To: Stephen Rothwell CC: Andrew Morton , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: linux-next: build failure after merge of the akpm tree References: <20110701151931.4c2d78b5.sfr@canb.auug.org.au> <4E0D5BD4.6080403@redhat.com> <20110701170843.bd60e326.sfr@canb.auug.org.au> <4E0D9D16.7020508@redhat.com> <20110701203702.a15ecf19.sfr@canb.auug.org.au> In-Reply-To: <20110701203702.a15ecf19.sfr@canb.auug.org.au> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 于 2011年07月01日 18:37, Stephen Rothwell 写道: > Hi, > > On Fri, 01 Jul 2011 18:10:30 +0800 Cong Wang wrote: >> >> 于 2011年07月01日 15:08, Stephen Rothwell 写道: >>> >>> On Fri, 01 Jul 2011 13:32:04 +0800 Cong Wang wrote: >>>> >>>> 于 2011年07月01日 13:19, Stephen Rothwell 写道: >>>>> >>>>> After merging the akpm tree, today's linux-next build (powerpc >>>>> ppc64_defconfig) failed like this: >>>>> >>>>> arch/powerpc/kernel/rtas.c: In function 'rtas_restart': >>>>> arch/powerpc/kernel/rtas.c:655:24: error: 'SYS_RESTART' undeclared (first use in this function) >>>>> arch/powerpc/kernel/rtas.c: In function 'rtas_power_off': >>>>> arch/powerpc/kernel/rtas.c:664:24: error: 'SYS_POWER_OFF' undeclared (first use in this function) >>>>> arch/powerpc/kernel/rtas.c: In function 'rtas_halt': >>>>> arch/powerpc/kernel/rtas.c:674:24: error: 'SYS_HALT' undeclared (first use in this function) >>>>> >>>>> Caused by commit ac050ff2a176 ("It is not necessary to share the same >>>>> notifier.h"). >>>> >>>> I think the following patch will fix this. >>> >>> Please find all the other files that need that include as well (there is >>> at least one more). >>> >> >> Ok, I will do a cross-compilation. > > Well, really any file that references any of those defines should be > including linux/reboot.h, now - whether a compilation gets errors or > not. A change in CONFIG options or different platforms/architectures can > change what file get implictly included. > > See Rule 1 in Documentation/SubmitChecklist. Yeah, I did allyesconfig test on x86. Fortunately there are few files that needs to be fixed since they include reboot.h implicitly. Thanks.