From: James Hogan <james.hogan@imgtec.com>
To: James Hogan <james.hogan@imgtec.com>
Cc: Chris Ball <cjb@laptop.org>, Will <will.newton@imgtec.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
linux-mmc <linux-mmc@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/4] mmc: dw_mmc: remove unnecessary error messages
Date: Wed, 06 Jul 2011 10:38:24 +0100 [thread overview]
Message-ID: <4E142D10.6080206@imgtec.com> (raw)
In-Reply-To: <4E142C10.3050508@imgtec.com>
Remove error messages for timeout and CRC failure, since the error code
already indicates the problem.
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Acked-by: Will Newton <will.newton@imgtec.com>
Tested-by: Jaehoon Chung <jh80.chung@samsung.com>
---
drivers/mmc/host/dw_mmc.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index fcff3c0..bf2157a 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -908,12 +908,8 @@ static void dw_mci_tasklet_func(unsigned long priv)
if (status & DW_MCI_DATA_ERROR_FLAGS) {
if (status & SDMMC_INT_DTO) {
- dev_err(&host->pdev->dev,
- "data timeout error\n");
data->error = -ETIMEDOUT;
} else if (status & SDMMC_INT_DCRC) {
- dev_err(&host->pdev->dev,
- "data CRC error\n");
data->error = -EILSEQ;
} else {
dev_err(&host->pdev->dev,
--
1.7.2.3
next prev parent reply other threads:[~2011-07-06 9:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-06 9:34 [PATCH v2 0/4] mmc: dw_mmc: mmc_test related fixes James Hogan
2011-07-06 9:37 ` [PATCH v2 1/4] mmc: dw_mmc: fix stop when fallen back to PIO James Hogan
2011-07-06 9:38 ` James Hogan [this message]
2011-07-06 9:39 ` [PATCH v2 3/4] mmc: dw_mmc: handle "no CRC status" error James Hogan
2011-07-06 9:40 ` [PATCH v2 4/4] mmc: dw_mmc: reset FIFO after an error James Hogan
-- strict thread matches above, loose matches on Subject: below --
2011-06-29 8:27 [PATCH 0/4] mmc: dw_mmc: mmc_test related fixes James Hogan
2011-06-29 8:29 ` [PATCH 2/4] mmc: dw_mmc: remove unnecessary error messages James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E142D10.6080206@imgtec.com \
--to=james.hogan@imgtec.com \
--cc=cjb@laptop.org \
--cc=jh80.chung@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=will.newton@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox