Re: [PATCH 07/12] Input: synaptics - rename synaptics_data.mt to agm

Henrik Rydberg
2011-07-04T21:25:01Z

On Wed, Jun 29, 2011 at 01:07:17PM +0800, djkurtz@chromium.org wrote:
> From: Daniel Kurtz <djkurtz@chromium.org>
>
> Rename the synaptics_data.mt field to priv->agm to indicate it is the
> hardware state reported in a synaptics AGM packet.
>
> When a Synaptics touchpad is in "AGM" mode, and multiple fingers are
> detected, the touchpad sends alternating "Advanced Gesture Mode" (AGM) and
> "Simple Gesture Mode" (SGM) packets.
> The AGM packets have w=2, and contain reduced resolution finger data.
> The SGM packets have w={0,1} and contain full resolution finger data.
>
> Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
> ---

How about just modifying the comment, i.e., leaving this hunk?

> @@ -147,7 +147,7 @@ struct synaptics_data {
>
> struct serio *pt_port; /* Pass-through serio port */
>
> - struct synaptics_hw_state mt; /* current gesture packet */
> + struct synaptics_hw_state agm; /* last AGM packet */
> };
>
> void synaptics_module_init(void);
> --

Thanks,
Henrik