From: Maarten Lankhorst <m.b.lankhorst@gmail.com>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: devel@linuxdriverproject.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [staging] mei: Enable msi when supported
Date: Thu, 07 Jul 2011 13:32:21 +0200 [thread overview]
Message-ID: <4E159945.8050900@gmail.com> (raw)
Signed-off-by: Maarten Lankhorst <m.b.lankhorst@gmail.com>
---
Tested suspend/resume, driver (re/un)loading. Comments welcome. :)
diff --git a/drivers/staging/mei/main.c b/drivers/staging/mei/main.c
index bfd1b46..58106bf 100644
--- a/drivers/staging/mei/main.c
+++ b/drivers/staging/mei/main.c
@@ -121,6 +121,7 @@ static int __devinit mei_probe(struct pci_dev *pdev,
{
struct mei_device *dev;
int err;
+ unsigned long flags = 0;
mutex_lock(&mei_mutex);
if (mei_device) {
@@ -154,11 +155,13 @@ static int __devinit mei_probe(struct pci_dev *pdev,
err = -ENOMEM;
goto free_device;
}
+ if (pci_enable_msi(pdev) < 0)
+ flags |= IRQF_SHARED;
/* request and enable interrupt */
err = request_threaded_irq(pdev->irq,
mei_interrupt_quick_handler,
mei_interrupt_thread_handler,
- IRQF_SHARED, mei_driver_name, dev);
+ flags, mei_driver_name, dev);
if (err) {
printk(KERN_ERR "mei: request_threaded_irq failure. irq = %d\n",
pdev->irq);
@@ -186,6 +189,7 @@ release_irq:
mei_disable_interrupts(dev);
flush_scheduled_work();
free_irq(pdev->irq, dev);
+ pci_disable_msi(pdev);
unmap_memory:
pci_iounmap(pdev, dev->mem_addr);
free_device:
@@ -250,6 +254,7 @@ static void __devexit mei_remove(struct pci_dev *pdev)
mei_disable_interrupts(dev);
free_irq(pdev->irq, dev);
+ pci_disable_msi(pdev);
pci_set_drvdata(pdev, NULL);
if (dev->mem_addr)
@@ -1103,7 +1108,7 @@ static int mei_pci_suspend(struct device *device)
mutex_unlock(&dev->device_lock);
free_irq(pdev->irq, dev);
-
+ pci_disable_msi(pdev);
return err;
}
@@ -1113,16 +1118,19 @@ static int mei_pci_resume(struct device *device)
struct pci_dev *pdev = to_pci_dev(device);
struct mei_device *dev;
int err;
+ unsigned long flags = 0;
dev = pci_get_drvdata(pdev);
if (!dev)
return -ENODEV;
+ if (pci_enable_msi(pdev) < 0)
+ flags |= IRQF_SHARED;
/* request and enable interrupt */
err = request_threaded_irq(pdev->irq,
mei_interrupt_quick_handler,
mei_interrupt_thread_handler,
- IRQF_SHARED, mei_driver_name, dev);
+ flags, mei_driver_name, dev);
if (err) {
printk(KERN_ERR "mei: Request_irq failure. irq = %d\n",
pdev->irq);
next reply other threads:[~2011-07-07 11:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-07 11:32 Maarten Lankhorst [this message]
2011-07-07 12:23 ` [staging] mei: Enable msi when supported Winkler, Tomas
2011-07-12 13:13 ` Maarten Lankhorst
2011-07-13 12:18 ` Winkler, Tomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E159945.8050900@gmail.com \
--to=m.b.lankhorst@gmail.com \
--cc=devel@linuxdriverproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox