From: "Pádraig Brady" <P@draigBrady.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Wim Van Sebroeck <wim@iguana.be>,
linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org
Subject: Re: [PATCH 0/2] [RFC] watchdog reboot timeout
Date: Thu, 07 Jul 2011 14:51:57 +0100 [thread overview]
Message-ID: <4E15B9FD.8080003@draigBrady.com> (raw)
In-Reply-To: <20110706160744.4002.94920.stgit@bhelgaas.mtv.corp.google.com>
On 06/07/11 17:09, Bjorn Helgaas wrote:
> I'm looking for comments on these patches. I'm not really happy with
> them because they add basically identical code in each driver. I also
> don't like the fact that the parameter is not generic, so I have to know
> which driver will be used on my machine.
Hmm, so this is protecting the window between watchdog_stop and machine_reset.
It would be nice to have this as generic code that did WDIOC_SETTIMEOUT
immediately after (or instead of) shutdown.
Leaving a watchdog enabled across boot does have issues on some systems.
It was OK for winboond based watchdogs I tested, but for some IBM
server systems, "weird stuff" happened if the watchdog was left enabled
across boot.
Just to mention the other watchdog boot scenario I often use
(which does _not_ protect your window above), which is to enable the
watchdog in the BIOS. This is more general protection for the
boot _up_ process. On a netboot system for example this will mean
that the system will keep rebooting until whatever switch is
down etc. is restored. Many systems I've used had support
for this in the BIOS and those that didn't were quickly updated
by vendors to do so.
A related issue I noticed with iTCO_wdt is that something
else in the kernel disables the iTCO watchdog (which my BIOS had started).
This is undesirable for obvious reasons.
cheers,
Pádraig.
next prev parent reply other threads:[~2011-07-07 13:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-06 16:09 [PATCH 0/2] [RFC] watchdog reboot timeout Bjorn Helgaas
2011-07-06 16:09 ` [PATCH 1/2] watchdog: iTCO_wdt: optionally leave watchdog enabled during restart Bjorn Helgaas
2011-07-07 15:39 ` Valdis.Kletnieks
2011-07-07 15:53 ` Pádraig Brady
2011-07-12 17:22 ` Bjorn Helgaas
2011-07-06 16:09 ` [PATCH 2/2] watchdog: nv_tco: " Bjorn Helgaas
2011-07-07 13:51 ` Pádraig Brady [this message]
2011-07-12 16:25 ` [PATCH 0/2] [RFC] watchdog reboot timeout Bjorn Helgaas
2011-07-12 21:36 ` Pádraig Brady
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E15B9FD.8080003@draigBrady.com \
--to=p@draigbrady.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox