From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753495Ab1GGQit (ORCPT ); Thu, 7 Jul 2011 12:38:49 -0400 Received: from mga01.intel.com ([192.55.52.88]:15365 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752237Ab1GGQio (ORCPT ); Thu, 7 Jul 2011 12:38:44 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.65,494,1304319600"; d="scan'208";a="27504698" Message-ID: <4E15E02A.2000005@linux.intel.com> Date: Thu, 07 Jul 2011 09:34:50 -0700 From: J Freyensee User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:5.0) Gecko/20110628 Thunderbird/5.0 MIME-Version: 1.0 To: Randy Dunlap CC: lkml , Stephen Rothwell , linux-next@vger.kernel.org Subject: Re: linux-next: Tree for July 4 (misc/pti) References: <20110704170952.1024e89b.sfr@canb.auug.org.au> <20110704134541.9adfd4f1.randy.dunlap@oracle.com> <20110707081441.a4a64e59.randy.dunlap@oracle.com> <4E15DF07.4010507@linux.intel.com> <20110707093202.a831fce8.randy.dunlap@oracle.com> In-Reply-To: <20110707093202.a831fce8.randy.dunlap@oracle.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/07/2011 09:32 AM, Randy Dunlap wrote: > On Thu, 07 Jul 2011 09:29:59 -0700 J Freyensee wrote: > >> On 07/07/2011 08:14 AM, Randy Dunlap wrote: >>> On Mon, 4 Jul 2011 13:45:41 -0700 Randy Dunlap wrote: >>> >>>> On Mon, 4 Jul 2011 17:09:52 +1000 Stephen Rothwell wrote: >>>> >>>>> Hi all, >>>>> >>>>> Changes since 20110701: >>>> when CONFIG_PCI is not enabled: >>>> >>>> drivers/misc/pti.c:410: error: implicit declaration of function 'pci_release_region' >>>> drivers/misc/pti.c:859: error: implicit declaration of function 'pci_request_region' >>>> >>>> >>>> Stubs for these 2 functions could be added to include/linux/pci.h, but it would >>>> make more sense to me just to make the driver depend on PCI since it seems to rely >>>> on so many PCI functions. or are the PCI pieces optional? >>> ping. still a problem in linux-next 20110706. >> Thanks for the ping. >> >> Is there something you need me to do or look at? >> >> For Intel-Atom architectures, the MIPI PTI module does sit on the PCI >> bus. It's very much dependent upon the PCI bus for working >> functionality and it's not optional. So yes, it makes sense for the >> driver to depend on PCI to be there and if PCI is not enabled on the >> system, don't build the pti driver. >> >> Maybe it's a Kconfig dependency? > Yes, please send/merge a patch that adds > depends on PCI > to "config INTEL_MID_PCI". And just for confirmation, you want me to base this patch on the linux-next git tree, correct? > Thanks. > --- > ~Randy > *** Remember to use Documentation/SubmitChecklist when testing your code ***