Re: [PATCH] Add PCI config dependency for PTI.

Randy Dunlap
2011-07-07T20:59:29Z

On 07/07/11 12:59, J Freyensee wrote:
> On 07/07/2011 12:31 PM, Randy Dunlap wrote:
>> On Thu, 7 Jul 2011 12:24:13 -0700 james_p_freyensee@linux.intel.com
>> wrote:
>>
>>> From: J Freyensee<james_p_freyensee@linux.intel.com>
>>>
>>> Intel-Atom implementation of PTI will not work with PCI
>>> configured off, so the pti driver should not be compiled
>>> in the event someone does not enable PCI in the linux kernel.
>>>
>>> Signed-off-by: J Freyensee<james_p_freyensee@linux.intel.com>
>>> Acked-by: Randy Dunlap<randy.dunlap@oracle.com>
>> now you can say that above. ^^^
> So you want me to stick the 'Acked-by' and 'Reported-by' above the
> Signed-off-by line?

You had Acked-by: prematurely.

Yes, now you can put both Acked-by: and Reported-by:
above the S-O-B: line.

>> Also
>> Reported-by: Randy Dunlap<randy.dunlap@oracle.com>
>>
>> Thanks.
>>
>>> Acked-by: Stephen Rothwell<sfr@canb.auug.org.au>
>>> ---
>>> drivers/misc/Kconfig | 1 +
>>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
>>> index 4e349cd..7fd32a6 100644
>>> --- a/drivers/misc/Kconfig
>>> +++ b/drivers/misc/Kconfig
>>> @@ -146,6 +146,7 @@ config PHANTOM
>>>
>>> config INTEL_MID_PTI
>>> tristate "Parallel Trace Interface for MIPI P1149.7 cJTAG
>>> standard"
>>> + depends on PCI
>>> default n
>>> help
>>> The PTI (Parallel Trace Interface) driver directs
>>> --
>>
>> ---
>> ~Randy
>> *** Remember to use Documentation/SubmitChecklist when testing your
>> code ***