Re: [PATCH] Change hypervisor detection order

["H. Peter Anvin" <hpa@zytor.com>]

On 07/07/2011 11:19 AM, Anupam Chanda wrote:
> Detect Xen before HyperV because in Viridian compatibility mode Xen presents
> itself as HyperV.
> 
> Signed-off-by: Anupam Chanda <achanda@nicira.com>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> ---
>  arch/x86/kernel/cpu/hypervisor.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/hypervisor.c b/arch/x86/kernel/cpu/hypervisor.c
> index 8095f86..ca23091 100644
> --- a/arch/x86/kernel/cpu/hypervisor.c
> +++ b/arch/x86/kernel/cpu/hypervisor.c
> @@ -33,10 +33,10 @@
>  static const __initconst struct hypervisor_x86 * const hypervisors[] =
>  {
>  	&x86_hyper_vmware,
> -	&x86_hyper_ms_hyperv,
>  #ifdef CONFIG_XEN_PVHVM
>  	&x86_hyper_xen_hvm,
>  #endif
> +	&x86_hyper_ms_hyperv,
>  };
>  
>  const struct hypervisor_x86 *x86_hyper;

Any reason to not hoist it to the top?  I'm guessing Xen emulating
VMware is more likely than the opposite...
	
	-hpa