From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756918Ab1GKAav (ORCPT ); Sun, 10 Jul 2011 20:30:51 -0400 Received: from eterpe-smout.broadpark.no ([80.202.8.16]:44342 "EHLO eterpe-smout.broadpark.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756799Ab1GKAau (ORCPT ); Sun, 10 Jul 2011 20:30:50 -0400 X-Greylist: delayed 3601 seconds by postgrey-1.27 at vger.kernel.org; Sun, 10 Jul 2011 20:30:50 EDT MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset=ISO-8859-10; format=flowed Message-id: <4E1A3627.9020606@broadpark.no> Date: Mon, 11 Jul 2011 01:30:47 +0200 From: =?ISO-8859-10?Q?Bj=F8rn_Forbord?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110516 Lightning/1.0b2 Thunderbird/3.1.10 To: Stefan Richter Cc: Clemens Ladisch , Joel bourrigaud , linux1394-devel@lists.sf.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] firewire: ohci: do not bind to Pinnacle or Fujitsu HCI, prevent panic References: <20110604002938.78c85881@stein> <20110604010625.1a37638e@stein> <4DEA697A.1090104@bourrigaud.info> <20110612145303.2099aa81@stein> <4DF4FF4F.4020607@bourrigaud.info> <20110612210111.3e979131@stein> <4DF528CF.50407@bourrigaud.info> <20110709235410.08004e5d@stein> <4E1A161D.1050304@ladisch.de> <20110711012422.1e585783@stein> In-reply-to: <20110711012422.1e585783@stein> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I saw these mails just now and it's late. I will check my machine and answer tomorrow Best regards Bjørn Den 11. juli 2011 01:24, skrev Stefan Richter: > When firewire-ohci is bound to a Pinnacle MovieBoard, eventually a > "Register access failure" is logged and an interrupt storm or a kernel > panic happens. https://bugzilla.kernel.org/show_bug.cgi?id=36622 > > Until this is sorted out (if that is going to succeed at all), let's > just prevent firewire-ohci from touching these devices. > > This device with link layer PCI IDs 11bd:0015 and 1394 PHY IDs > 00000e:086613 is apparently a Fujitsu MB86613 --- hence the PHY IDs. > Therefore, blacklist the MB86613 too (PCI IDs 10cf:200c). We only check > the vendor ID because there is no other Fujitsu OHCI-1394 PCI device > known besides this one. > > Signed-off-by: Stefan Richter > Cc: > --- > Supersedes patch "firewire: ohci: do not bind to Pinnacle cards, prevent panic" > > drivers/firewire/ohci.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > Index: b/drivers/firewire/ohci.c > =================================================================== > --- a/drivers/firewire/ohci.c > +++ b/drivers/firewire/ohci.c > @@ -260,6 +260,8 @@ static inline struct fw_ohci *fw_ohci(st > > static char ohci_driver_name[] = KBUILD_MODNAME; > > +#define PCI_VENDOR_ID_FUJITSU 0x10cf > +#define PCI_VENDOR_ID_PINNACLE_SYSTEMS 0x11bd > #define PCI_DEVICE_ID_AGERE_FW643 0x5901 > #define PCI_DEVICE_ID_JMICRON_JMB38X_FW 0x2380 > #define PCI_DEVICE_ID_TI_TSB12LV22 0x8009 > @@ -3202,6 +3204,12 @@ static int __devinit pci_probe(struct pc > int i, err; > size_t size; > > + if (dev->vendor == PCI_VENDOR_ID_FUJITSU || > + dev->vendor == PCI_VENDOR_ID_PINNACLE_SYSTEMS) { > + dev_err(&dev->dev, "Controller type is not yet supported\n"); > + return -ENOSYS; > + } > + > ohci = kzalloc(sizeof(*ohci), GFP_KERNEL); > if (ohci == NULL) { > err = -ENOMEM; > >