* mmotm 2011-07-08-12-50 uploaded @ 2011-07-08 19:50 akpm 2011-07-10 18:44 ` [PATCH -mmotm] misc: fix eeprom printk format Randy Dunlap 2011-07-11 20:27 ` page->_count build failure [was: mmotm 2011-07-08-12-50 uploaded] Jiri Slaby 0 siblings, 2 replies; 9+ messages in thread From: akpm @ 2011-07-08 19:50 UTC (permalink / raw) To: mm-commits, linux-kernel, linux-mm, linux-fsdevel The mm-of-the-moment snapshot 2011-07-08-12-50 has been uploaded to http://userweb.kernel.org/~akpm/mmotm/ and will soon be available at git://zen-kernel.org/kernel/mmotm.git or git://git.cmpxchg.org/linux-mmotm.git It contains the following patches against 3.0-rc6: origin.patch headers_check-is-broken.patch mm-vmscan-correct-check-for-kswapd-sleeping-in-sleeping_prematurely.patch mm-vmscan-do-not-apply-pressure-to-slab-if-we-are-not-applying-pressure-to-zone.patch mm-vmscan-evaluate-the-watermarks-against-the-correct-classzone.patch mm-vmscan-only-read-new_classzone_idx-from-pgdat-when-reclaiming-successfully.patch mm-__tlb_remove_page-checks-correct-batch.patch memcg-fix-reclaimable-lru-check-in-memcg.patch memcg-fix-reclaimable-lru-check-in-memcg-checkpatch-fixes.patch memcg-fix-reclaimable-lru-check-in-memcg-fix.patch memcg-fix-reclaimable-lru-check-in-memcg-fix-2.patch memcg-fix-numa-scan-information-update-to-be-triggered-by-memory-event.patch memcg-fix-numa-scan-information-update-to-be-triggered-by-memory-event-fix.patch mm-preallocate-page-before-lock_page-at-filemap-cow.patch mm-preallocate-page-before-lock_page-at-filemap-cow-fix.patch w1-ds1wm-add-a-reset-recovery-parameter.patch w1-ds1wm-add-a-reset-recovery-parameter-checkpatch-fixes.patch mm-nommuc-fix-remap_pfn_range.patch mm-nommuc-fix-remap_pfn_range-update.patch drivers-leds-leds-pca9532c-change-driver-name-to-be-unique.patch maintainers-update-bjorn-helgaass-email-address.patch xtensa-prevent-arbitrary-read-in-ptrace.patch xtensa-prevent-arbitrary-read-in-ptrace-fix.patch mm-cleanup-descriptions-of-filler-arg.patch mm-truncate-functions-are-in-truncatec.patch mm-tidy-vmtruncate_range-and-related-functions.patch mm-consistent-truncate-and-invalidate-loops.patch mm-pincer-in-truncate_inode_pages_range.patch tmpfs-no-need-to-use-i_lock.patch linux-next.patch linux-next-git-rejects.patch i-need-old-gcc.patch arch-alpha-kernel-systblss-remove-debug-check.patch drivers-misc-pch_phubc-dont-oops-if-dmi_get_system_info-returns-null.patch bdi_min_ratio-never-shrinks-ultimately-preventing-valid-setting-of-min_ratio.patch mm-mempolicyc-make-copy_from_user-provably-correct.patch drivers-cpufreq-acpi-cpufreqc-fix-memory-leak.patch cris-fix-a-build-error-in-kernel-forkc.patch cris-fix-a-build-error-in-kernel-forkc-checkpatch-fixes.patch cris-fix-a-build-error-in-sync_serial_open.patch cris-fix-the-prototype-of-sync_serial_ioctl.patch cris-add-missing-declaration-of-kgdb_init-and-breakpoint.patch drivers-platform-x86-dell-laptopc-revert-dell-laptop-toggle-the-unsupported-hardware-killswitch.patch drivers-scsi-pmcraid-reject-negative-request-size.patch drivers-scsi-iprc-reorder-error-handling-code-to-include-iounmap.patch kernel-timec-change-jiffies_to_clock_t-input-parameters-type-to-unsigned-long.patch kernel-timec-change-jiffies_to_clock_t-input-parameters-type-to-unsigned-long-fix.patch thermal-hide-config_thermal_hwmon.patch thermal-split-hwmon-lookup-to-a-separate-function.patch thermal-make-thermal_hwmon-implementation-fully-internal.patch acpi-remove-nid_inval.patch acpi-add-missing-_osi-strings-resend.patch acerhdf-add-support-for-aspire-1410-bios-v13314.patch arch-x86-platform-iris-irisc-register-a-platform-device-and-a-platform-driver.patch arch-x86-platform-iris-irisc-register-a-platform-device-and-a-platform-driver-fix.patch arch-x86-platform-iris-irisc-register-a-platform-device-and-a-platform-driver-fix-2.patch arch-x86-include-asm-delayh-fix-udelay-and-ndelay-for-8-bit-args.patch x86-fix-mmap-random-address-range.patch leds-new-pcengines-alix-system-driver-enables-leds-via-gpio-interface.patch arch-x86-kernel-e820c-eliminate-bubble-sort-from-sanitize_e820_map.patch x86-olpc-add-missing-elements-to-device-tree.patch x86-olpc-move-cs5536-related-constants-to-cs5535h.patch x86-olpc-rename-olpc-xo1-to-olpc-xo1-pm.patch x86-olpc-add-xo-1-suspend-resume-support.patch x86-olpc-add-xo-1-sci-driver-and-power-button-control.patch x86-olpc-ec-sci-wakeup-mask-functionality.patch x86-olpc-xo1-sci-add-gpe-handler-and-ebook-switch-functionality.patch x86-olpc-xo1-sci-add-lid-switch-functionality.patch x86-olpc-xo1-sci-propagate-power-supply-battery-events.patch x86-olpc-add-xo-1-rtc-driver.patch x86-olpc-add-xo-15-sci-driver.patch arch-arm-mach-ux500-mbox-db5500c-world-writable-sysfs-fifo-file.patch arm-exec-remove-redundant-set_fsuser_ds.patch audit-always-follow-va_copy-with-va_end.patch btrfs-dont-dereference-extent_mapping-if-null.patch drivers-block-drbd-drbd_nlc-use-bitmap_parse-instead-of-__bitmap_parse.patch ppc-exec-remove-redundant-set_fsuser_ds.patch fb-fix-potential-deadlock-between-lock_fb_info-and-console_lock.patch cyber2000fb-avoid-palette-corruption-at-higher-clocks.patch genirq-fix-missing-parenthesises-in-generic-chip.patch ia64-exec-remove-redundant-set_fsuser_ds.patch kernel-makefile-prevent-unnecessary-rebuilding-due-to-config_datagz.patch microblaze-exec-remove-redundant-set_fsuser_ds.patch mips-exec-remove-redundant-addr_limit-assignment.patch unicore32-exec-remove-redundant-set_fsuser_ds.patch maintainers-orphan-framerelay-dlci.patch drivers-net-skgec-support-dlink-dge-530t-rev-c1.patch drivers-video-backlight-ld9040c-small-fixes.patch backlight-add-ams369fg06-amoled-driver.patch backlight-add-ams369fg06-amoled-driver-fix.patch backlight-add-ams369fg06-amoled-driver-unregister-backlight-device-when-unload-the-module.patch backlight-ams369fg06-fix-section-mismatch-warning.patch backlight-ams369fg06-staticize-ams369fg06_shutdown.patch backlight-set-backlight-type-and-max_brightness-before-backlights-are-registered.patch drivers-video-backlight-aat2870_blc-fix-error-checking-for-backlight_device_register.patch drivers-video-backlight-aat2870_blc-fix-setting-max_current.patch drivers-video-backlight-aat2870_blc-make-it-buildable-as-a-module.patch i915-add-native-backlight-control.patch btusb-patch-add_apple_macbookpro62.patch ext4-use-proper-little-endian-bitops.patch ocfs2-avoid-unaligned-access-to-dqc_bitmap.patch parisc-exec-remove-redundant-set_fsuser_ds.patch pci-dmar-update-dmar-units-devices-list-during-hotplug.patch drivers-firmware-dmi_scanc-make-dmi_name_in_vendors-more-focused.patch pci-enumerate-the-pci-device-only-removed-out-pci-hierarchy-of-os-when-re-scanning-pci.patch pci-enumerate-the-pci-device-only-removed-out-pci-hierarchy-of-os-when-re-scanning-pci-fix.patch pci-make-the-struct-pci_dev-argument-of-pci_fixup_irqs-const.patch s390-exec-remove-redundant-set_fsuser_ds.patch scsi-fix-a-header-to-include-linux-typesh.patch drivers-scsi-megaraidc-fix-sparse-warnings.patch drivers-scsi-aacraid-commctrlc-fix-mem-leak-in-aac_send_raw_srb.patch drivers-block-brdc-make-brd_make_request-return-error-code.patch block-genhdc-remove-useless-cast-in-diskstats_show.patch drivers-block-loopc-emit-uevent-on-auto-release.patch sparc-exec-remove-redundant-addr_limit-assignment.patch drivers-staging-speakup-devsynthc-fix-buffer-size-is-not-provably-correct-error.patch drivers-staging-gma500-psb_intel_displayc-fix-build.patch drivers-staging-dt3155v4l-dt3155v4lc-needs-slabh.patch drivers-staging-solo6x10-corec-needs-slabh.patch drivers-staging-solo6x10-p2mc-needs-slabh.patch staging-more-missing-slabh-inclusions.patch slab-use-numa_no_node.patch mm.patch mm-extend-memory-hotplug-api-to-allow-memory-hotplug-in-virtual-machines.patch mm-extend-memory-hotplug-api-to-allow-memory-hotplug-in-virtual-machines-fix.patch xen-balloon-memory-hotplug-support-for-xen-balloon-driver.patch mm-swap-token-fix-dead-link.patch mm-swap-token-makes-global-variables-to-function-local.patch mm-swap-token-add-a-comment-for-priority-aging.patch pagewalk-fix-walk_page_range-dont-check-find_vma-result-properly.patch pagewalk-dont-look-up-vma-if-walk-hugetlb_entry-is-unused.patch pagewalk-add-locking-rule-comments.patch pagewalk-add-locking-rule-comments-fix.patch pagewalk-fix-code-comment-for-thp.patch mm-remove-the-leftovers-of-noswapaccount.patch mm-page_cgroupc-simplify-code-by-using-section_align_up-and-section_align_down-macros.patch mm-thp-minor-lock-simplification-in-__khugepaged_exit.patch mm-hugetlb-fix-coding-style-issues.patch mm-memoryc-remove-zap_block_size.patch oom-remove-references-to-old-badness-function.patch oom-make-deprecated-use-of-oom_adj-more-verbose.patch mm-memblockc-avoid-abuse-of-red_inactive.patch tmpfs-clone-shmem_file_splice_read.patch tmpfs-refine-shmem_file_splice_read.patch tmpfs-pass-gfp-to-shmem_getpage_gfp.patch tmpfs-remove_shmem_readpage.patch tmpfs-simplify-prealloc_page.patch tmpfs-simplify-filepage-swappage.patch tmpfs-simplify-unuse-and-writepage.patch radix_tree-exceptional-entries-and-indices.patch mm-let-swap-use-exceptional-entries.patch tmpfs-demolish-old-swap-vector-support.patch tmpfs-miscellaneous-trivial-cleanups.patch tmpfs-copy-truncate_inode_pages_range.patch tmpfs-convert-shmem_truncate_range-to-radix-swap.patch tmpfs-convert-shmem_unuse_inode-to-radix-swap.patch tmpfs-convert-shmem_getpage_gfp-to-radix-swap.patch tmpfs-convert-mem_cgroup-shmem-to-radix-swap.patch tmpfs-convert-shmem_writepage-and-enable-swap.patch tmpfs-use-kmemdup-for-short-symlinks.patch mm-a-few-small-updates-for-radix-swap.patch mm-a-few-small-updates-for-radix-swap-fix.patch tmpfs-expand-help-to-explain-value-of-tmpfs_posix_acl.patch tmpfs-expand-help-to-explain-value-of-tmpfs_posix_acl-v3.patch frv-hook-up-gpiolib-support.patch frv-exec-remove-redundant-set_fsuser_ds.patch frv-duplicate-output_buffer-of-e03.patch frv-duplicate-output_buffer-of-e03-checkpatch-fixes.patch h8300-exec-remove-redundant-set_fsuser_ds.patch hpet-factor-timer-allocate-from-open.patch alpha-exec-remove-redundant-set_fsuser_ds.patch m32r-exec-remove-redundant-set_fsuser_ds.patch m68k-exec-remove-redundant-set_fsuser_ds.patch mn10300-exec-remove-redundant-set_fsuser_ds.patch intel_idle-fix-api-misuse.patch intel_idle-disable-auto_demotion-for-hotplugged-cpus.patch cris-fix-some-build-warnings-in-pinmuxc.patch cris-exec-remove-redundant-set_fsuser_ds.patch um-clean-up-vm-flagsh.patch um-exec-remove-redundant-set_fsuser_ds.patch um-clean-up-delay-functions-v2.patch um-fix-_fortify_source=2-support-for-kernel-modules.patch um-add-netpoll-support.patch um-reinstate-kernel-version-in-generated-config.patch drivers-use-kzalloc-kcalloc-instead-of-kmallocmemset-where-possible.patch asm-generic-systemh-drop-useless-__kernel__.patch kprobes-silence-debug_strict_user_copy_checks=y-warning.patch x86-implement-strict-user-copy-checks-for-x86_64.patch consolidate-config_debug_strict_user_copy_checks.patch devres-fix-possible-use-after-free.patch geode-reflect-mfgpt-dependency-on-mfd.patch drivers-misc-add-support-the-fsa9480-usb-switch.patch drivers-misc-add-support-the-fsa9480-usb-switch-fix.patch notifiers-cpu-move-cpu-notifiers-into-cpuh.patch notifiers-net-move-netdevice-notifiers-into-netdeviceh.patch notifiers-sys-move-reboot-notifiers-into-rebooth.patch notifiers-sys-move-reboot-notifiers-into-rebooth-fix.patch notifiers-pm-move-pm-notifiers-into-suspendh.patch notifiers-pm-move-pm-notifiers-into-suspendh-update.patch notifiers-vt-move-vt-notifiers-into-vth.patch kernel-configsc-include-module_-when-config_ikconfig_proc=n.patch fs-locksc-remove-init_once.patch fcntlf_setfl-allow-setting-of-o_sync.patch get_maintainerspl-improve-mailmap-parsing.patch maintainers-update-high-resolution-timers-patterns.patch leds-lp5521-provide-section-tagging.patch drivers-leds-leds-sunfirec-fix-sunfire_led_generic_probe-error-handling.patch leds-lm3530-calibrate-als-input-voltage.patch mach-ux500-add-lm3530-als-platform-data-for-u5500.patch leds-route-kbd-leds-through-the-generic-leds-layer.patch lib-lcmc-quiet-sparse-noise.patch compat_ioctl-fix-warning-caused-by-qemu.patch checkpatch-suggest-using-min_t-or-max_t-v2.patch checkpatch-add-__rcu-as-a-sparse-modifier.patch checkpatch-validate-signature-styles-and-to-and-cc-lines.patch checkpatch-add-a-prefer-__aligned-check.patch checkpatchpl-add-ability-to-ignore-various-messages.patch checkpatch-make-utf-8-test-strict.patch misc-eeprom-add-driver-for-microwire-93xx46-eeproms.patch misc-eeprom-add-eeprom-access-driver-for-digsy_mtc-board.patch lib-hexdumpc-make-hex2bin-return-the-updated-src-address.patch fs-binfmt_miscc-use-kernels-hex_to_bin-method.patch fs-binfmt_miscc-use-kernels-hex_to_bin-method-fix.patch fs-binfmt_miscc-use-kernels-hex_to_bin-method-fix-fix.patch init-skip-calibration-delay-if-previously-done.patch init-skip-calibration-delay-if-previously-done-fix.patch init-skip-calibration-delay-if-previously-done-fix-fix.patch init-skip-calibration-delay-if-previously-done-fix-fix-fix.patch init-skip-calibration-delay-if-previously-done-4.patch drivers-rtc-rtc-mpc5121c-add-support-for-rtc-on-mpc5200.patch drivers-rtc-rtc-s3cc-support-clock-gating.patch drivers-rtc-add-support-for-qualcomm-pmic8xxx-rtc.patch drivers-rtc-add-support-for-qualcomm-pmic8xxx-rtc-fix.patch drivers-rtc-add-support-for-qualcomm-pmic8xxx-rtc-do-not-use-mfd_get_data.patch drivers-rtc-rtc-twlc-check-return-value-of-twl_rtc_write_u8-in-twl_rtc_set_time.patch pnpacpi-register-disabled-resources.patch reiserfs-use-proper-little-endian-bitops.patch reiserfs-use-hweight_long.patch documentation-submitchecklist-add-rcu-debug-config-options.patch memcg-export-memory-cgroups-swappiness-with-mem_cgroup_swappiness.patch memcg-consolidates-memory-cgroup-lru-stat-functions.patch memcg-consolidates-memory-cgroup-lru-stat-functions-fix.patch memcg-do-not-expose-uninitialized-mem_cgroup_per_node-to-world.patch cpusets-randomize-node-rotor-used-in-cpuset_mem_spread_node.patch cpusets-randomize-node-rotor-used-in-cpuset_mem_spread_node-fix-2.patch cpusets-randomize-node-rotor-used-in-cpuset_mem_spread_node-cpusets-initialize-spread-rotor-lazily.patch cpusets-randomize-node-rotor-used-in-cpuset_mem_spread_node-cpusets-initialize-spread-rotor-lazily-fix.patch ptrace-unify-show_regs-prototype.patch ptrace-unify-show_regs-prototype-fix.patch coredump-use-task-comm-instead-of-unknown.patch coredump-escape-in-hostname-and-comm.patch do_coredump-fix-the-ispipe-error-check.patch h8300-m68k-xtensa-__fd_isset-should-return-0-1.patch proc-pid-fdinfo-add-cloexec-information.patch proc-pid-fdinfo-add-cloexec-information-fix.patch procfs-return-enoent-on-opening-a-being-removed-proc-entry.patch proc-fix-a-race-in-do_io_accounting.patch kernel-forkc-fix-a-few-coding-style-issues.patch fs-execc-use-build_bug_on-for-vm_stack_flags-vm_stack_incomplete_setup.patch exec-do-not-call-request_module-twice-from-search_binary_handler.patch cpumask-convert-for_each_cpumask-with-for_each_cpu.patch cpumask-alloc_cpumask_var-use-numa_no_node.patch cpumask-add-cpumask_var_t-documentation.patch ipc-mqueue-refactor-failure-handling.patch ipc-mqueue-fix-mq_open-return-value.patch ipc-introduce-shm_rmid_forced-sysctl.patch ipc-introduce-shm_rmid_forced-sysctl-fix.patch ipc-introduce-shm_rmid_forced-sysctl-fix-2.patch ipc-introduce-shm_rmid_forced-sysctl-cleanup.patch ipc-introduce-shm_rmid_forced-sysctl-comments.patch ipc-introduce-shm_rmid_forced-sysctl-comments-fix.patch ipc-introduce-shm_rmid_forced-sysctl-testing.patch init-add-root=partuuid=uuid-partnroff=%d-support.patch documentation-add-pointer-to-name_to_dev_t-for-root=-values.patch sysctl-add-proc_dointvec_bool-handler.patch sysctl-use-proc_dointvec_bool-where-appropriate.patch sysctl-add-proc_dointvec_unsigned-handler.patch sysctl-add-proc_dointvec_unsigned-handler-update.patch sysctl-use-proc_dointvec_unsigned-where-appropriate.patch gcov-disable-constructors-for-uml.patch include-linux-dma-mappingh-remove-dma_xxbit_mask-macros.patch scatterlist-new-helper-functions.patch scatterlist-new-helper-functions-update.patch scatterlist-new-helper-functions-update-fix.patch memstick-add-support-for-legacy-memorysticks.patch memstick-add-support-for-legacy-memorysticks-update-2.patch drivers-w1-slaves-w1_thermc-add-support-for-ds28ea00.patch kexec-remove-kmsg_dump_kexec.patch ramoops-use-module-parameters-instead-of-platform-data-if-not-available.patch ramoops-use-module-parameters-instead-of-platform-data-if-not-available-checkpatch-fixes.patch ramoops-add-new-line-to-each-print.patch ramoops-move-dump_oops-into-platform-data.patch ramoops-make-record_size-a-module-parameter.patch ramoops-add-debugfs-entry.patch fault-injection-do-not-include-unneeded-header.patch fault-injection-remove-nonexistent-function-extern.patch fault-injection-cleanup-simple-attribute-of-stacktrace_depth.patch fault-injection-use-debugfs_remove_recursive.patch failslab-simplify-debugfs-initialization.patch fail_page_alloc-simplify-debugfs-initialization.patch fail_make_request-cleanup-should_fail_request.patch asm-generic-add-another-generic-ext2-atomic-bitops.patch atomic-use-linux-atomich.patch atomic-move-atomic_add_unless-to-generic-code.patch atomic-cleanup-asm-generic-atomich-inclusion.patch atomic-update-comments-in-atomich.patch asm-generic-atomich-simplify-inc-dec-test-helpers.patch asm-generic-atomich-fix-type-used-in-atomic_clear_mask.patch asm-generic-atomich-add-atomic_set_mask-helper.patch asm-generic-atomich-allow-smp-peeps-to-leverage-this.patch make-sure-nobodys-leaking-resources.patch journal_add_journal_head-debug.patch releasing-resources-with-children.patch make-frame_pointer-default=y.patch mutex-subsystem-synchro-test-module.patch mutex-subsystem-synchro-test-module-fix.patch slab-leaks3-default-y.patch put_bh-debug.patch add-debugging-aid-for-memory-initialisation-problems.patch workaround-for-a-pci-restoring-bug.patch prio_tree-debugging-patch.patch single_open-seq_release-leak-diagnostics.patch add-a-refcount-check-in-dput.patch memblock-add-input-size-checking-to-memblock_find_region.patch memblock-add-input-size-checking-to-memblock_find_region-fix.patch ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH -mmotm] misc: fix eeprom printk format 2011-07-08 19:50 mmotm 2011-07-08-12-50 uploaded akpm @ 2011-07-10 18:44 ` Randy Dunlap 2011-07-11 20:27 ` page->_count build failure [was: mmotm 2011-07-08-12-50 uploaded] Jiri Slaby 1 sibling, 0 replies; 9+ messages in thread From: Randy Dunlap @ 2011-07-10 18:44 UTC (permalink / raw) To: akpm, Anatolij Gustschin; +Cc: linux-kernel From: Randy Dunlap <randy.dunlap@oracle.com> drivers/misc/eeprom/eeprom_93xx46.c:95: warning: format '%d' expects type 'int', but argument 3 has type 'size_t' Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Cc: Anatolij Gustschin <agust@denx.de> applies-to: misc-eeprom-add-driver-for-microwire-93xx46-eeproms.patch --- drivers/misc/eeprom/eeprom_93xx46.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- mmotm-2011-0708-1250.orig/drivers/misc/eeprom/eeprom_93xx46.c +++ mmotm-2011-0708-1250/drivers/misc/eeprom/eeprom_93xx46.c @@ -91,7 +91,7 @@ eeprom_93xx46_bin_read(struct file *filp /* have to wait at least Tcsl ns */ ndelay(250); if (ret) { - dev_err(&edev->spi->dev, "read %d bytes at %d: err. %d\n", + dev_err(&edev->spi->dev, "read %zu bytes at %d: err. %d\n", count, (int)off, ret); } ^ permalink raw reply [flat|nested] 9+ messages in thread
* page->_count build failure [was: mmotm 2011-07-08-12-50 uploaded] 2011-07-08 19:50 mmotm 2011-07-08-12-50 uploaded akpm 2011-07-10 18:44 ` [PATCH -mmotm] misc: fix eeprom printk format Randy Dunlap @ 2011-07-11 20:27 ` Jiri Slaby 2011-07-11 20:41 ` Andrew Morton 1 sibling, 1 reply; 9+ messages in thread From: Jiri Slaby @ 2011-07-11 20:27 UTC (permalink / raw) To: linux-kernel; +Cc: akpm, mm-commits, cl On 07/08/2011 09:50 PM, akpm@linux-foundation.org wrote: > The mm-of-the-moment snapshot 2011-07-08-12-50 has been uploaded to Hi, am I the only one encountering a build failure due to double definition of _count in page struct introduced by: commit fc9bb8c768abe7ae10861c3510e01a95f98d5933 Author: Christoph Lameter <cl@linux.com> Date: Wed Jun 1 12:25:48 2011 -0500 mm: Rearrange struct page in the -next tree? $ make ... CC arch/x86/kernel/asm-offsets.s In file included from include/linux/sched.h:64:0, from arch/x86/kernel/asm-offsets.c:9: include/linux/mm_types.h:74:15: error: duplicate member ‘_count’ make[1]: *** [arch/x86/kernel/asm-offsets.s] Error 1 make: *** [prepare0] Error 2 $ gcc --version gcc (SUSE Linux) 4.6.0 20110607 [gcc-4_6-branch revision 174741] regards, -- js ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: page->_count build failure [was: mmotm 2011-07-08-12-50 uploaded] 2011-07-11 20:27 ` page->_count build failure [was: mmotm 2011-07-08-12-50 uploaded] Jiri Slaby @ 2011-07-11 20:41 ` Andrew Morton 2011-07-11 20:45 ` Pekka Enberg 0 siblings, 1 reply; 9+ messages in thread From: Andrew Morton @ 2011-07-11 20:41 UTC (permalink / raw) To: Jiri Slaby; +Cc: linux-kernel, cl, Pekka Enberg On Mon, 11 Jul 2011 22:27:22 +0200 Jiri Slaby <jirislaby@gmail.com> wrote: > On 07/08/2011 09:50 PM, akpm@linux-foundation.org wrote: > > The mm-of-the-moment snapshot 2011-07-08-12-50 has been uploaded to > > Hi, am I the only one encountering a build failure due to double > definition of _count in page struct introduced by: > commit fc9bb8c768abe7ae10861c3510e01a95f98d5933 > Author: Christoph Lameter <cl@linux.com> > Date: Wed Jun 1 12:25:48 2011 -0500 > > mm: Rearrange struct page > > in the -next tree? > > $ make > ... > CC arch/x86/kernel/asm-offsets.s > In file included from include/linux/sched.h:64:0, > from arch/x86/kernel/asm-offsets.c:9: > include/linux/mm_types.h:74:15: error: duplicate member ____count___ > make[1]: *** [arch/x86/kernel/asm-offsets.s] Error 1 > make: *** [prepare0] Error 2 > $ gcc --version > gcc (SUSE Linux) 4.6.0 20110607 [gcc-4_6-branch revision 174741] > Oh dear. Yes, I would call that an error. Afacit the two `_count's end up at the same offset in the page struct. Perhaps that makes it legal and your compiler got it wrong. Or perhaps it is illegal and all other compilers got it wrong. Still, we should fix it. It's daft to have two distinct page->_count's. To fix it, we could rename one of them. Which means that we're going to need to work out which references to page->_count are referring to which field. Which demonstrates the problem! hmm, let's jiggle the offset: --- a/include/linux/mm_types.h~a +++ a/include/linux/mm_types.h @@ -71,6 +71,7 @@ struct page { * Kernel may make use of this field even when slub * uses the rest of the double word! */ + int foo; atomic_t _count; }; }; _ nope, it still compiles OK. It has to be gcc bustification I think. Fixed in gcc-4.6.0. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: page->_count build failure [was: mmotm 2011-07-08-12-50 uploaded] 2011-07-11 20:41 ` Andrew Morton @ 2011-07-11 20:45 ` Pekka Enberg 2011-07-11 20:47 ` Jiri Slaby 2011-07-11 21:04 ` Jiri Slaby 0 siblings, 2 replies; 9+ messages in thread From: Pekka Enberg @ 2011-07-11 20:45 UTC (permalink / raw) To: Andrew Morton; +Cc: Jiri Slaby, linux-kernel, cl, Pekka Enberg On Mon, Jul 11, 2011 at 11:41 PM, Andrew Morton <akpm@linux-foundation.org> wrote: > On Mon, 11 Jul 2011 22:27:22 +0200 > Jiri Slaby <jirislaby@gmail.com> wrote: > >> On 07/08/2011 09:50 PM, akpm@linux-foundation.org wrote: >> > The mm-of-the-moment snapshot 2011-07-08-12-50 has been uploaded to >> >> Hi, am I the only one encountering a build failure due to double >> definition of _count in page struct introduced by: >> commit fc9bb8c768abe7ae10861c3510e01a95f98d5933 >> Author: Christoph Lameter <cl@linux.com> >> Date: Wed Jun 1 12:25:48 2011 -0500 >> >> mm: Rearrange struct page >> >> in the -next tree? >> >> $ make >> ... >> CC arch/x86/kernel/asm-offsets.s >> In file included from include/linux/sched.h:64:0, >> from arch/x86/kernel/asm-offsets.c:9: >> include/linux/mm_types.h:74:15: error: duplicate member ____count___ >> make[1]: *** [arch/x86/kernel/asm-offsets.s] Error 1 >> make: *** [prepare0] Error 2 >> $ gcc --version >> gcc (SUSE Linux) 4.6.0 20110607 [gcc-4_6-branch revision 174741] >> > > Oh dear. Yes, I would call that an error. Afacit the two `_count's > end up at the same offset in the page struct. Perhaps that makes it > legal and your compiler got it wrong. Or perhaps it is illegal and all > other compilers got it wrong. > > Still, we should fix it. It's daft to have two distinct page->_count's. > > To fix it, we could rename one of them. Which means that we're going > to need to work out which references to page->_count are referring to > which field. Which demonstrates the problem! > > > hmm, let's jiggle the offset: > > --- a/include/linux/mm_types.h~a > +++ a/include/linux/mm_types.h > @@ -71,6 +71,7 @@ struct page { > * Kernel may make use of this field even when slub > * uses the rest of the double word! > */ > + int foo; > atomic_t _count; > }; > }; > _ > > nope, it still compiles OK. It has to be gcc bustification I think. > Fixed in gcc-4.6.0. Didn't commit ea6bd8ee1a2ccdffc38b2b1fcfe941addfafaade fix the issue? ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: page->_count build failure [was: mmotm 2011-07-08-12-50 uploaded] 2011-07-11 20:45 ` Pekka Enberg @ 2011-07-11 20:47 ` Jiri Slaby 2011-07-11 20:51 ` Pekka Enberg 2011-07-11 21:04 ` Jiri Slaby 1 sibling, 1 reply; 9+ messages in thread From: Jiri Slaby @ 2011-07-11 20:47 UTC (permalink / raw) To: Pekka Enberg; +Cc: Andrew Morton, linux-kernel, cl, Pekka Enberg On 07/11/2011 10:45 PM, Pekka Enberg wrote: > On Mon, Jul 11, 2011 at 11:41 PM, Andrew Morton > <akpm@linux-foundation.org> wrote: >> On Mon, 11 Jul 2011 22:27:22 +0200 >> Jiri Slaby <jirislaby@gmail.com> wrote: >> >>> On 07/08/2011 09:50 PM, akpm@linux-foundation.org wrote: >>>> The mm-of-the-moment snapshot 2011-07-08-12-50 has been uploaded to >>> >>> Hi, am I the only one encountering a build failure due to double >>> definition of _count in page struct introduced by: >>> commit fc9bb8c768abe7ae10861c3510e01a95f98d5933 >>> Author: Christoph Lameter <cl@linux.com> >>> Date: Wed Jun 1 12:25:48 2011 -0500 >>> >>> mm: Rearrange struct page >>> >>> in the -next tree? >>> >>> $ make >>> ... >>> CC arch/x86/kernel/asm-offsets.s >>> In file included from include/linux/sched.h:64:0, >>> from arch/x86/kernel/asm-offsets.c:9: >>> include/linux/mm_types.h:74:15: error: duplicate member ____count___ >>> make[1]: *** [arch/x86/kernel/asm-offsets.s] Error 1 >>> make: *** [prepare0] Error 2 >>> $ gcc --version >>> gcc (SUSE Linux) 4.6.0 20110607 [gcc-4_6-branch revision 174741] >>> >> >> Oh dear. Yes, I would call that an error. Afacit the two `_count's >> end up at the same offset in the page struct. Perhaps that makes it >> legal and your compiler got it wrong. Or perhaps it is illegal and all >> other compilers got it wrong. >> >> Still, we should fix it. It's daft to have two distinct page->_count's. >> >> To fix it, we could rename one of them. Which means that we're going >> to need to work out which references to page->_count are referring to >> which field. Which demonstrates the problem! >> >> >> hmm, let's jiggle the offset: >> >> --- a/include/linux/mm_types.h~a >> +++ a/include/linux/mm_types.h >> @@ -71,6 +71,7 @@ struct page { >> * Kernel may make use of this field even when slub >> * uses the rest of the double word! >> */ >> + int foo; >> atomic_t _count; >> }; >> }; >> _ >> >> nope, it still compiles OK. It has to be gcc bustification I think. >> Fixed in gcc-4.6.0. > > Didn't commit ea6bd8ee1a2ccdffc38b2b1fcfe941addfafaade fix the issue? Which repo is that from? Git doesn't know it here. thanks, -- js ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: page->_count build failure [was: mmotm 2011-07-08-12-50 uploaded] 2011-07-11 20:47 ` Jiri Slaby @ 2011-07-11 20:51 ` Pekka Enberg 2011-07-11 21:00 ` Andrew Morton 0 siblings, 1 reply; 9+ messages in thread From: Pekka Enberg @ 2011-07-11 20:51 UTC (permalink / raw) To: Jiri Slaby; +Cc: Andrew Morton, linux-kernel, cl, Pekka Enberg On Mon, Jul 11, 2011 at 11:47 PM, Jiri Slaby <jirislaby@gmail.com> wrote: >> Didn't commit ea6bd8ee1a2ccdffc38b2b1fcfe941addfafaade fix the issue? > > Which repo is that from? Git doesn't know it here. It's in slab.git: http://git.kernel.org/?p=linux/kernel/git/penberg/slab-2.6.git;a=commitdiff;h=ea6bd8ee1a2ccdffc38b2b1fcfe941addfafaade Maybe linux-next hasn't picked it up yet? ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: page->_count build failure [was: mmotm 2011-07-08-12-50 uploaded] 2011-07-11 20:51 ` Pekka Enberg @ 2011-07-11 21:00 ` Andrew Morton 0 siblings, 0 replies; 9+ messages in thread From: Andrew Morton @ 2011-07-11 21:00 UTC (permalink / raw) To: Pekka Enberg; +Cc: Jiri Slaby, linux-kernel, cl, Pekka Enberg On Mon, 11 Jul 2011 23:51:17 +0300 Pekka Enberg <penberg@kernel.org> wrote: > On Mon, Jul 11, 2011 at 11:47 PM, Jiri Slaby <jirislaby@gmail.com> wrote: > >> Didn't commit ea6bd8ee1a2ccdffc38b2b1fcfe941addfafaade fix the issue? > > > > Which repo is that from? Git doesn't know it here. > > It's in slab.git: > > http://git.kernel.org/?p=linux/kernel/git/penberg/slab-2.6.git;a=commitdiff;h=ea6bd8ee1a2ccdffc38b2b1fcfe941addfafaade > > Maybe linux-next hasn't picked it up yet? linux-next won't be updated for another week... ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: page->_count build failure [was: mmotm 2011-07-08-12-50 uploaded] 2011-07-11 20:45 ` Pekka Enberg 2011-07-11 20:47 ` Jiri Slaby @ 2011-07-11 21:04 ` Jiri Slaby 1 sibling, 0 replies; 9+ messages in thread From: Jiri Slaby @ 2011-07-11 21:04 UTC (permalink / raw) To: Pekka Enberg; +Cc: Andrew Morton, linux-kernel, cl, Pekka Enberg On 07/11/2011 10:45 PM, Pekka Enberg wrote: > Didn't commit ea6bd8ee1a2ccdffc38b2b1fcfe941addfafaade fix the issue? Yeah, it does. thanks, -- js ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2011-07-11 21:04 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-07-08 19:50 mmotm 2011-07-08-12-50 uploaded akpm 2011-07-10 18:44 ` [PATCH -mmotm] misc: fix eeprom printk format Randy Dunlap 2011-07-11 20:27 ` page->_count build failure [was: mmotm 2011-07-08-12-50 uploaded] Jiri Slaby 2011-07-11 20:41 ` Andrew Morton 2011-07-11 20:45 ` Pekka Enberg 2011-07-11 20:47 ` Jiri Slaby 2011-07-11 20:51 ` Pekka Enberg 2011-07-11 21:00 ` Andrew Morton 2011-07-11 21:04 ` Jiri Slaby
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox