Re: [PATCH 1/3] perf: add context field to perf_event

Avi Kivity
2011-07-12T10:36:39Z

On 07/12/2011 01:24 PM, Joerg Roedel wrote:
> On Tue, Jul 12, 2011 at 01:07:25PM +0300, Avi Kivity wrote:
> > On 07/12/2011 01:03 PM, Joerg Roedel wrote:
>
> >> Ingo made perf-integration a merge-requirement for LWP. It is not really
> >> well-suited for being integrated into perf because the design goal was
> >> easy and efficient self-profiling of tasks (like you stated). So
> >> integrating it into perf causes some pain. But lets see how it works
> >> out.
> >
> > I don't think it's workable. Having do_mmap() called in the task's
> > context can change how it works.
>
> According to Ingo that is already done at other places in the kernel and
> should not be an issue.

kvm is one of those places, unfortunately.

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.