public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: `make headers_check' bustage
Date: Tue, 12 Jul 2011 18:34:09 +0200	[thread overview]
Message-ID: <4E1C7781.5080406@suse.cz> (raw)
In-Reply-To: <20110712090156.c051d864.akpm@linux-foundation.org>

On 12.7.2011 18:01, Andrew Morton wrote:
> On Tue, 12 Jul 2011 16:04:55 +0200 Michal Marek<mmarek@suse.cz>  wrote:
>> Nevertheless, these errors are pretty harmless, the prototypes do not
>> break parsing the header when compiling userspace programs.
>
> Well, it's a bit harmful - someone did an exit(non-zero) and `make'
> terminates the build with a build error.

That's strange, scripts/headers_check.pl only exits with non-zero if it 
finds that a included header file is not exported:

			printf STDERR "$filename:$lineno: included file '$inc' is not 
exported\n";
			$ret = 1;

in all other cases the $ret assignment is commented out:

		# Warn until headers are all fixed
		#$ret = 1;

and it works for me on both v3.0-rc7 and next-20110707.

Michal

  reply	other threads:[~2011-07-12 16:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-08  0:16 `make headers_check' bustage Andrew Morton
2011-07-08 12:54 ` Vitaliy Ivanov
2011-07-12 14:04 ` Michal Marek
2011-07-12 16:01   ` Andrew Morton
2011-07-12 16:34     ` Michal Marek [this message]
2011-07-17 21:47 ` Randy Dunlap
2011-07-20  9:26   ` Vitaliy Ivanov
2011-07-20  9:30     ` Michal Marek
2011-07-20  9:36       ` Vitaliy Ivanov
2011-07-20  9:43         ` Michal Marek
2011-07-20 15:24           ` Andrew Morton
2011-07-21  5:15   ` Américo Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E1C7781.5080406@suse.cz \
    --to=mmarek@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox