From: "H. Peter Anvin" <hpa@zytor.com>
To: Matthew Garrett <mjg@redhat.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH 1/2] efi: merge x86 and ia64 code
Date: Wed, 13 Jul 2011 11:57:38 -0700 [thread overview]
Message-ID: <4E1DEAA2.80208@zytor.com> (raw)
In-Reply-To: <1310502243-19306-1-git-send-email-mjg@redhat.com>
On 07/12/2011 01:24 PM, Matthew Garrett wrote:
> We currently have two almost entirely independent EFI implementations in
> the kernel, with the x86 code having begun as a modified version of the
> ia64 code. Forthcoming ARM platforms will use EFI and there are
> experimental ports for some MIPS platforms, so continuing this "One EFI
> implementation per architecture" model is likely to result in massive bug
> duplication. This patch merges the common elements of the ia64 and x86
> implementations, which should make adding any future platforms a simple
> matter of adding setup code and the appropriate stubs for accessing EFI
> resources and making calls.
>
> Signed-off-by: Matthew Garrett <mjg@redhat.com>
Hi Matt,
I get a build error on x86-32:
/home/hpa/kernel/linux-2.6-tip.efi/arch/x86/platform/efi/efi_32.c:43:
error: conflicting types for ‘efi_call_phys_prelog’
/home/hpa/kernel/linux-2.6-tip.efi/arch/x86/include/asm/efi.h:73: note:
previous declaration of ‘efi_call_phys_prelog’ was here
/home/hpa/kernel/linux-2.6-tip.efi/arch/x86/platform/efi/efi_32.c:85:
error: conflicting types for ‘efi_call_phys_epilog’
/home/hpa/kernel/linux-2.6-tip.efi/arch/x86/include/asm/efi.h:74: note:
previous declaration of ‘efi_call_phys_epilog’ was here
make[5]: *** [arch/x86/platform/efi/efi_32.o] Error 1
-hpa
next prev parent reply other threads:[~2011-07-13 18:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-12 20:24 [PATCH 1/2] efi: merge x86 and ia64 code Matthew Garrett
2011-07-12 20:24 ` [PATCH 2/2] MAINTAINERS: Add a maintainer for EFI Matthew Garrett
2011-07-12 20:40 ` Joe Perches
2011-07-13 18:57 ` H. Peter Anvin [this message]
2011-07-13 19:58 ` [PATCH 1/2] efi: merge x86 and ia64 code Matthew Garrett
2011-07-13 19:59 ` [PATCH V2 " Matthew Garrett
2011-07-13 19:59 ` [PATCH V2 2/2] MAINTAINERS: Add a maintainer for EFI Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E1DEAA2.80208@zytor.com \
--to=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox