Re: [PATCH 2.5/13] memblock: Use __meminit[data] instead of __init[data]

H. Peter Anvin
2011-07-14T21:24:55Z

On 07/14/2011 02:00 PM, Yinghai Lu wrote:
>>
>> diff --git a/include/linux/memblock.h b/include/linux/memblock.h
>> index aa5df9e..434b958 100644
>> --- a/include/linux/memblock.h
>> +++ b/include/linux/memblock.h
>> @@ -152,8 +152,8 @@ static inline unsigned long memblock_region_reserved_end_pfn(const struct memblo
>>
>>
>> #ifdef ARCH_DISCARD_MEMBLOCK
>> -#define __init_memblock __init
>> -#define __initdata_memblock __initdata
>> +#define __init_memblock __meminit
>> +#define __initdata_memblock __meminitdata
>> #else
>> #define __init_memblock
>> #define __initdata_memblock
>
> that is not good. It will keep memblock.reserved related data and
> functions after boot.
> and those data/func are not used after slab is ready.
>

>From the look of it this ranges from about 7-19K, so I'm going to take
this and we can optimize this later.

-hpa