Re: [PATCH 2.5/13] memblock: Use __meminit[data] instead of __init[data]

Yinghai Lu
2011-07-14T21:00:54Z

On Thu, Jul 14, 2011 at 2:42 AM, Tejun Heo <tj@kernel.org> wrote:
> From 19ab281ed67b87a6623d725237a7333ca79f1e75 Mon Sep 17 00:00:00 2001
> From: Tejun Heo <tj@kernel.org>
> Date: Thu, 14 Jul 2011 11:22:16 +0200
>
> memblock will be extended to include early_node_map[], which is also
> used during memory hotplug.  Make memblock use __meminit[data] instead
> of __init[data] so that memory hotplug code can safely reference it.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Reported-by: Yinghai Lu <yinghai@kernel.org>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
>  include/linux/memblock.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/memblock.h b/include/linux/memblock.h
> index aa5df9e..434b958 100644
> --- a/include/linux/memblock.h
> +++ b/include/linux/memblock.h
> @@ -152,8 +152,8 @@ static inline unsigned long memblock_region_reserved_end_pfn(const struct memblo
>
>
>  #ifdef ARCH_DISCARD_MEMBLOCK
> -#define __init_memblock __init
> -#define __initdata_memblock __initdata
> +#define __init_memblock __meminit
> +#define __initdata_memblock __meminitdata
>  #else
>  #define __init_memblock
>  #define __initdata_memblock

that is not good. It will keep memblock.reserved related data and
functions after boot.
and those data/func are not used after slab is ready.

Thanks

Yinghai