Re: [PATCH 04/13] x86: Use HAVE_MEMBLOCK_NODE_MAP

H. Peter Anvin
2011-07-14T01:36:20Z

On 07/12/2011 02:15 AM, Tejun Heo wrote:
> Convert x86 to HAVE_MEMBLOCK_NODE_MAP. The only difference in memory
> handling is that allocations can't no longer cross node boundaries
> whether they're node affine or not, which shouldn't matter at all.
>
> This conversion will enable further simplification of boot memory
> handling.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Yinghai Lu <yinghai@kernel.org>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>

Hi Tejun,

This patch causes a build error on i386 allnoconfig:

/home/hpa/kernel/linux-2.6-tip.memblock/arch/x86/mm/init_32.c: In
function ‘initmem_init’:
/home/hpa/kernel/linux-2.6-tip.memblock/arch/x86/mm/init_32.c:653:2:
error: implicit declaration of function
‘memblock_x86_register_active_regions’
[-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors

-hpa