Re: [PATCH 13/13] memblock, x86: Replace memblock_x86_reserve/free_range() with generic ones

Tejun Heo
2011-07-26T21:46:14Z

Hello, Yinghai.

On Tue, Jul 26, 2011 at 11:06 PM, Yinghai Lu <yhlu.kernel@gmail.com> wrote:
> Wonder if we have a new function like
>
> __memblock_reserve(addr, size, name)
>
> in mm/memblock.c
>
> so could keep string for debug purpose instead of using _RET_IP_.
>
> with that, we can figure out what is in exact reserved position with boot log.

If you look at the current users, the caller function name is unique
except for one or two cases, so we can already tell who's doing what
even without consulting the exact IP. I can't see much point in
providing debug strings explicitly. The only benefit would be that it
would be prettier but these are purely debug messages. One thing
which might make sense is preserving _RET_IP_ of callers of alloc
functions so that reserve can show who's allocating instead of
printing the alloc function each time.

Thanks.

--
tejun