Re: [PATCHSET x86/mm] memblock, x86: Allow node info in memblock and remove x86 specific memblock code

Tejun Heo
2011-07-13T09:11:37Z

Hello, Yinghai.

On Tue, Jul 12, 2011 at 04:26:57PM -0700, Yinghai Lu wrote:
> On Tue, Jul 12, 2011 at 2:15 AM, Tejun Heo <tj@kernel.org> wrote:
> > 0005-0013 adds generic memblock free area iterator and gradually
> > replaces x86 specific memblock mechanism with generic one.
>
> that is great, merge early_node_map into memblock array.

Yeah and with proper top down allocator and iterator, we should be
able to add back the early per-node allocaiton thing.

> looks it comes with some mismatch section warning...
>
> WARNING: vmlinux.o(.text+0x120ba5): Section mismatch in reference from
> the function memblock_set_node() to the variable .init.data:memblock
> The function memblock_set_node() references
> the variable __initdata memblock.
> This is often because memblock_set_node lacks a __initdata
> annotation or the annotation of memblock is wrong.

Oh, the __memblock_init thing. Can you please attach .config you
used?

Thanks.

--
tejun