From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751464Ab1GOMag (ORCPT ); Fri, 15 Jul 2011 08:30:36 -0400 Received: from mms1.broadcom.com ([216.31.210.17]:1064 "EHLO mms1.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751058Ab1GOMaf (ORCPT ); Fri, 15 Jul 2011 08:30:35 -0400 X-Server-Uuid: 02CED230-5797-4B57-9875-D5D2FEE4708A Message-ID: <4E2032D7.9000704@broadcom.com> Date: Fri, 15 Jul 2011 14:30:15 +0200 From: "Roland Vossen" Organization: Broadcom User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.17) Gecko/20110424 Thunderbird/3.1.10 MIME-Version: 1.0 To: "Rafael J. Wysocki" cc: "Jonas Gorski" , "Geert Uytterhoeven" , "devel@linuxdriverproject.org" , "linux-kernel@vger.kernel.org" , "linux-mips@linux-mips.org" Subject: Re: Status of MIPS on 3.0.0-rc6 kernel References: <4E1ECE3B.10308@broadcom.com> <201107142151.24763.rjw@sisk.pl> In-Reply-To: <201107142151.24763.rjw@sisk.pl> X-WSS-ID: 623EEB993B421038137-01-01 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Please check if the appended patch helps. It does, I am able to build a big endian MIPS kernel now. Can you notify me if you submit this patch ? Thanks, Roland. > > Thanks, > Rafael > > --- > From: Rafael J. Wysocki > Subject: MIPS: Convert i8259.c to using syscore_ops > > The code in arch/mips/kernel/i8259.c still hasn't been converted to > using struct syscore_ops instead of a sysdev for resume and shutdown. > As a result, this code doesn't build any more after suspend, resume > and shutdown callbacks have been removed from struct sysdev_class. > Fix this problem by converting i8259.c to using syscore_ops. > > Signed-off-by: Rafael J. Wysocki > --- > arch/mips/kernel/i8259.c | 22 ++++++---------------- > 1 file changed, 6 insertions(+), 16 deletions(-) > > Index: linux-2.6/arch/mips/kernel/i8259.c > =================================================================== > --- linux-2.6.orig/arch/mips/kernel/i8259.c > +++ linux-2.6/arch/mips/kernel/i8259.c > @@ -14,7 +14,7 @@ > #include > #include > #include > -#include > +#include > #include > > #include > @@ -215,14 +215,13 @@ spurious_8259A_irq: > } > } > > -static int i8259A_resume(struct sys_device *dev) > +static void i8259A_resume(void) > { > if (i8259A_auto_eoi>= 0) > init_8259A(i8259A_auto_eoi); > - return 0; > } > > -static int i8259A_shutdown(struct sys_device *dev) > +static void i8259A_shutdown(void) > { > /* Put the i8259A into a quiescent state that > * the kernel initialization code can get it > @@ -232,26 +231,17 @@ static int i8259A_shutdown(struct sys_de > outb(0xff, PIC_MASTER_IMR); /* mask all of 8259A-1 */ > outb(0xff, PIC_SLAVE_IMR); /* mask all of 8259A-1 */ > } > - return 0; > } > > -static struct sysdev_class i8259_sysdev_class = { > - .name = "i8259", > +static struct syscore_ops i8259_syscore_ops = { > .resume = i8259A_resume, > .shutdown = i8259A_shutdown, > }; > > -static struct sys_device device_i8259A = { > - .id = 0, > - .cls =&i8259_sysdev_class, > -}; > - > static int __init i8259A_init_sysfs(void) > { > - int error = sysdev_class_register(&i8259_sysdev_class); > - if (!error) > - error = sysdev_register(&device_i8259A); > - return error; > + register_syscore_ops(&i8259_syscore_ops); > + return 0; > } > > device_initcall(i8259A_init_sysfs); >