Re: [Patch] mm: make CONFIG_NUMA depend on CONFIG_SYSFS

Mel Gorman
2011-07-18T13:52:52Z

On Mon, Jul 18, 2011 at 07:18:29PM +0800, Amerigo Wang wrote:
> On ppc, we got this build error with randconfig:
>
> drivers/built-in.o:(.toc1+0xf90): undefined reference to `vmstat_text': 1 errors in 1 logs
>
> This is due to that it enabled CONFIG_NUMA but not CONFIG_SYSFS.
>
> And the user-space tool numactl depends on sysfs files too.
> So, I think it is very reasonable to make CONFIG_NUMA depend on CONFIG_SYSFS.
>

That looks a bit awful. There is no obvious connection between SYSFS
and NUMA. One is exporting information to userspace and the other is
the memory model. Without sysfs, NUMA support might be less useful
but the memory policies should still work and set_mempolicy() should
still be an option.

You didn't post where the buggy reference to vmstat_text but I'm
assuming it is in drivers/base/node.c . It would be preferable that
it be fixed to not reference vmstat_text unless either CONFIG_PROC_FS
or CONFIG_SYSFS is defined similar to what is in mm/vmstat.c .

--
Mel Gorman
SUSE Labs