From: J Freyensee <james_p_freyensee@linux.intel.com>
To: Per Forlin <per.forlin@linaro.org>
Cc: linaro-dev@lists.linaro.org,
Nicolas Pitre <nicolas.pitre@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-doc@vger.kernel.org, Venkatraman S <svenkatr@ti.com>,
Linus Walleij <linus.walleij@linaro.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Arnd Bergmann <arnd@arndb.de>,
Sourav Poddar <sourav.poddar@ti.com>, Chris Ball <cjb@laptop.org>,
Akinobu Mita <akinobu.mita@gmail.com>,
Randy Dunlap <rdunlap@xenotime.net>
Subject: Re: [PATCH v2 1/3] fault-inject: make fault injection available for modules
Date: Tue, 19 Jul 2011 16:44:29 -0700 [thread overview]
Message-ID: <4E2616DD.3010607@linux.intel.com> (raw)
In-Reply-To: <1311111106-26814-2-git-send-email-per.forlin@linaro.org>
On 07/19/2011 02:31 PM, Per Forlin wrote:
> export symbols should_fail() and init_fault_attr_dentries() in order
> to make modules use the fault injection functionality
>
> Signed-off-by: Per Forlin<per.forlin@linaro.org>
> ---
> lib/fault-inject.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/lib/fault-inject.c b/lib/fault-inject.c
> index 7e65af7..cd28364 100644
> --- a/lib/fault-inject.c
> +++ b/lib/fault-inject.c
> @@ -131,6 +131,7 @@ bool should_fail(struct fault_attr *attr, ssize_t size)
>
> return true;
> }
> +EXPORT_SYMBOL(should_fail);
Should this be EXPORT_SYMBOL_GPL()?
>
> #ifdef CONFIG_FAULT_INJECTION_DEBUG_FS
>
> @@ -311,5 +312,6 @@ fail:
> cleanup_fault_attr_dentries(attr);
> return -ENOMEM;
> }
> +EXPORT_SYMBOL(init_fault_attr_dentries);
and here too?
>
> #endif /* CONFIG_FAULT_INJECTION_DEBUG_FS */
--
J (James/Jay) Freyensee
Storage Technology Group
Intel Corporation
next prev parent reply other threads:[~2011-07-19 23:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 21:31 [PATCH v2 0/3] Make fault injection available for MMC IO Per Forlin
2011-07-19 21:31 ` [PATCH v2 1/3] fault-inject: make fault injection available for modules Per Forlin
2011-07-19 23:44 ` J Freyensee [this message]
2011-07-20 21:50 ` Per Forlin
2011-07-19 21:31 ` [PATCH v2 2/3] mmc: core: add random fault injection Per Forlin
2011-07-20 0:04 ` J Freyensee
2011-07-20 21:49 ` Per Forlin
2011-07-19 21:31 ` [PATCH v2 3/3] fault injection: add documentation on MMC IO " Per Forlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2616DD.3010607@linux.intel.com \
--to=james_p_freyensee@linux.intel.com \
--cc=akinobu.mita@gmail.com \
--cc=arnd@arndb.de \
--cc=cjb@laptop.org \
--cc=kyungmin.park@samsung.com \
--cc=linaro-dev@lists.linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=per.forlin@linaro.org \
--cc=rdunlap@xenotime.net \
--cc=sourav.poddar@ti.com \
--cc=svenkatr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox