From: "H. Peter Anvin" <hpa@zytor.com>
To: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
fweisbec@gmail.com, a.p.zijlstra@chello.nl, stable@kernel.org,
dsahern@gmail.com, tglx@linutronix.de, mingo@elte.hu
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/urgent] perf tools, x86: Fix 32-bit compile on 64-bit system
Date: Thu, 21 Jul 2011 09:07:07 -0700 [thread overview]
Message-ID: <4E284EAB.1020906@zytor.com> (raw)
In-Reply-To: <tip-08a4a43fc407d780bdde36d98f89c0dbb2a6be6b@git.kernel.org>
On 07/21/2011 08:36 AM, tip-bot for David Ahern wrote:
> Commit-ID: 08a4a43fc407d780bdde36d98f89c0dbb2a6be6b
> Gitweb: http://git.kernel.org/tip/08a4a43fc407d780bdde36d98f89c0dbb2a6be6b
> Author: David Ahern <dsahern@gmail.com>
> AuthorDate: Mon, 11 Jul 2011 15:38:24 -0600
> Committer: Ingo Molnar <mingo@elte.hu>
> CommitDate: Thu, 21 Jul 2011 13:42:30 +0200
>
> perf tools, x86: Fix 32-bit compile on 64-bit system
>
> Builds for 32-bit perf binaries on a 64-bit host currently fail
> with this error:
>
> [...]
> bench/../../../arch/x86/lib/memcpy_64.S: Assembler messages:
> bench/../../../arch/x86/lib/memcpy_64.S:29: Error: bad register name `%rdi'
> bench/../../../arch/x86/lib/memcpy_64.S:34: Error: invalid instruction suffix for `movs'
> bench/../../../arch/x86/lib/memcpy_64.S:50: Error: bad register name `%rdi'
> bench/../../../arch/x86/lib/memcpy_64.S:61: Error: bad register name `%rdi'
> ...
>
> The problem is the detection of the host arch without considering passed in
> flags. This change fixes 32-bit builds via:
>
> make EXTRA_CFLAGS=-m32
>
> and 64-bit builds still reference the memcpy_64.S.
>
But this is the wrong way to build 32-bit code on 64-bit platforms.
make ARCH=i386 is the supported way.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2011-07-21 16:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-11 21:38 [PATCH] perf tools, x86: fix 32-bit compile on 64-bit system David Ahern
2011-07-15 15:27 ` David Ahern
2011-07-15 15:32 ` Frederic Weisbecker
2011-07-15 15:38 ` Peter Zijlstra
2011-07-21 14:30 ` David Ahern
2011-07-21 15:36 ` [tip:perf/urgent] perf tools, x86: Fix " tip-bot for David Ahern
2011-07-21 16:07 ` H. Peter Anvin [this message]
2011-07-21 16:24 ` David Ahern
2011-07-21 18:03 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E284EAB.1020906@zytor.com \
--to=hpa@zytor.com \
--cc=a.p.zijlstra@chello.nl \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=stable@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox