* [PATCH] cciss: do not attempt to read from a write-only register
@ 2011-07-08 19:58 Stephen M. Cameron
2011-07-09 7:02 ` Jens Axboe
0 siblings, 1 reply; 6+ messages in thread
From: Stephen M. Cameron @ 2011-07-08 19:58 UTC (permalink / raw)
To: axboe; +Cc: stephenmcameron, akpm, mikem, linux-kernel, thenzl
From: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Most smartarrays will tolerate it, but some new ones don't.
Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
---
drivers/block/cciss.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/block/cciss.h b/drivers/block/cciss.h
index 16b4d58..c049548 100644
--- a/drivers/block/cciss.h
+++ b/drivers/block/cciss.h
@@ -223,7 +223,7 @@ static void SA5_submit_command( ctlr_info_t *h, CommandList_struct *c)
h->ctlr, c->busaddr);
#endif /* CCISS_DEBUG */
writel(c->busaddr, h->vaddr + SA5_REQUEST_PORT_OFFSET);
- readl(h->vaddr + SA5_REQUEST_PORT_OFFSET);
+ readl(h->vaddr + SA5_SCRATCHPAD_OFFSET);
h->commands_outstanding++;
if ( h->commands_outstanding > h->max_outstanding)
h->max_outstanding = h->commands_outstanding;
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] cciss: do not attempt to read from a write-only register
2011-07-08 19:58 Stephen M. Cameron
@ 2011-07-09 7:02 ` Jens Axboe
0 siblings, 0 replies; 6+ messages in thread
From: Jens Axboe @ 2011-07-09 7:02 UTC (permalink / raw)
To: Stephen M. Cameron; +Cc: stephenmcameron, akpm, mikem, linux-kernel, thenzl
On 2011-07-08 21:58, Stephen M. Cameron wrote:
> From: Stephen M. Cameron <scameron@beardog.cce.hp.com>
>
> Most smartarrays will tolerate it, but some new ones don't.
Thanks, I'll queue this for 3.1 and mark for stable backport.
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] cciss: do not attempt to read from a write-only register
@ 2011-07-21 18:16 Stephen M. Cameron
2011-07-21 18:17 ` Stephen Cameron
2011-07-22 22:39 ` Andrew Morton
0 siblings, 2 replies; 6+ messages in thread
From: Stephen M. Cameron @ 2011-07-21 18:16 UTC (permalink / raw)
To: axboe; +Cc: stephenmcameron, akpm, mikem, linux-kernel, thenzl
From: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Most smartarrays will tolerate it, but some new ones don't.
Without this change some newer Smart Arrays will lock up
and i/o will grind to a halt.
Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
---
drivers/block/cciss.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/block/cciss.h b/drivers/block/cciss.h
index 16b4d58..c049548 100644
--- a/drivers/block/cciss.h
+++ b/drivers/block/cciss.h
@@ -223,7 +223,7 @@ static void SA5_submit_command( ctlr_info_t *h, CommandList_struct *c)
h->ctlr, c->busaddr);
#endif /* CCISS_DEBUG */
writel(c->busaddr, h->vaddr + SA5_REQUEST_PORT_OFFSET);
- readl(h->vaddr + SA5_REQUEST_PORT_OFFSET);
+ readl(h->vaddr + SA5_SCRATCHPAD_OFFSET);
h->commands_outstanding++;
if ( h->commands_outstanding > h->max_outstanding)
h->max_outstanding = h->commands_outstanding;
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] cciss: do not attempt to read from a write-only register
2011-07-21 18:16 [PATCH] cciss: do not attempt to read from a write-only register Stephen M. Cameron
@ 2011-07-21 18:17 ` Stephen Cameron
2011-07-22 22:39 ` Andrew Morton
1 sibling, 0 replies; 6+ messages in thread
From: Stephen Cameron @ 2011-07-21 18:17 UTC (permalink / raw)
To: Stephen M. Cameron; +Cc: axboe, akpm, mikem, linux-kernel, thenzl
On Thu, Jul 21, 2011 at 1:16 PM, Stephen M. Cameron
<scameron@beardog.cce.hp.com> wrote:
> From: Stephen M. Cameron <scameron@beardog.cce.hp.com>
>
> Most smartarrays will tolerate it, but some new ones don't.
> Without this change some newer Smart Arrays will lock up
> and i/o will grind to a halt.
>
Noticed this wasn't in Linus's git tree yet, so resent it.
-- steve
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cciss: do not attempt to read from a write-only register
2011-07-21 18:16 [PATCH] cciss: do not attempt to read from a write-only register Stephen M. Cameron
2011-07-21 18:17 ` Stephen Cameron
@ 2011-07-22 22:39 ` Andrew Morton
2011-07-23 11:46 ` Jens Axboe
1 sibling, 1 reply; 6+ messages in thread
From: Andrew Morton @ 2011-07-22 22:39 UTC (permalink / raw)
To: Stephen M. Cameron
Cc: axboe, stephenmcameron, mikem, linux-kernel, thenzl, stable
On Thu, 21 Jul 2011 13:16:01 -0500
"Stephen M. Cameron" <scameron@beardog.cce.hp.com> wrote:
> From: Stephen M. Cameron <scameron@beardog.cce.hp.com>
>
> Most smartarrays will tolerate it, but some new ones don't.
> Without this change some newer Smart Arrays will lock up
> and i/o will grind to a halt.
>
> Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
No Cc: <stable@kernel.org>?
> drivers/block/cciss.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/block/cciss.h b/drivers/block/cciss.h
> index 16b4d58..c049548 100644
> --- a/drivers/block/cciss.h
> +++ b/drivers/block/cciss.h
> @@ -223,7 +223,7 @@ static void SA5_submit_command( ctlr_info_t *h, CommandList_struct *c)
> h->ctlr, c->busaddr);
> #endif /* CCISS_DEBUG */
> writel(c->busaddr, h->vaddr + SA5_REQUEST_PORT_OFFSET);
> - readl(h->vaddr + SA5_REQUEST_PORT_OFFSET);
> + readl(h->vaddr + SA5_SCRATCHPAD_OFFSET);
> h->commands_outstanding++;
> if ( h->commands_outstanding > h->max_outstanding)
> h->max_outstanding = h->commands_outstanding;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cciss: do not attempt to read from a write-only register
2011-07-22 22:39 ` Andrew Morton
@ 2011-07-23 11:46 ` Jens Axboe
0 siblings, 0 replies; 6+ messages in thread
From: Jens Axboe @ 2011-07-23 11:46 UTC (permalink / raw)
To: Andrew Morton
Cc: Stephen M. Cameron, stephenmcameron, mikem, linux-kernel, thenzl,
stable
On 2011-07-23 00:39, Andrew Morton wrote:
> On Thu, 21 Jul 2011 13:16:01 -0500
> "Stephen M. Cameron" <scameron@beardog.cce.hp.com> wrote:
>
>> From: Stephen M. Cameron <scameron@beardog.cce.hp.com>
>>
>> Most smartarrays will tolerate it, but some new ones don't.
>> Without this change some newer Smart Arrays will lock up
>> and i/o will grind to a halt.
>>
>> Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
>
> No Cc: <stable@kernel.org>?
Patch is already queued up in for-3.1/drivers since July 9th, and I also
marked it stable.
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-07-23 11:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-21 18:16 [PATCH] cciss: do not attempt to read from a write-only register Stephen M. Cameron
2011-07-21 18:17 ` Stephen Cameron
2011-07-22 22:39 ` Andrew Morton
2011-07-23 11:46 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2011-07-08 19:58 Stephen M. Cameron
2011-07-09 7:02 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox