From: Jens Axboe <jaxboe@fusionio.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Roland Dreier <roland@purestorage.com>,
Dave Jiang <dave.jiang@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [RFC PATCH 1/2] block: strict rq_affinity
Date: Sat, 23 Jul 2011 20:41:31 +0200 [thread overview]
Message-ID: <4E2B15DB.4090302@fusionio.com> (raw)
In-Reply-To: <20110722205938.17420.68621.stgit@localhost6.localdomain6>
On 2011-07-22 22:59, Dan Williams wrote:
> Some storage controllers benefit from completions always being steered
> to the strict requester cpu rather than the looser "per-socket" steering
> that blk_cpu_to_group() attempts by default.
>
> echo 2 > /sys/block/<bdev>/queue/rq_affinity
I have applied this one, with a modified patch description.
I like the adaptive solution, but it should be rewritten to not declare
and expose softirq internals. Essentially have an API from
kernel/softirq.c that can return whether a given (or perhaps just local)
softirq handler is busy or not.
--
Jens Axboe
next prev parent reply other threads:[~2011-07-23 18:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-22 20:59 [RFC PATCH 0/2] block: rq_affinity performance fixes Dan Williams
2011-07-22 20:59 ` [RFC PATCH 1/2] block: strict rq_affinity Dan Williams
2011-07-23 1:46 ` Christoph Hellwig
2011-07-23 18:38 ` Jens Axboe
2011-07-23 18:41 ` Jens Axboe [this message]
2011-07-25 1:14 ` Shaohua Li
2011-07-25 8:21 ` Jens Axboe
2011-07-22 20:59 ` [RFC PATCH 2/2] block: adaptive rq_affinity Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2B15DB.4090302@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=roland@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox