[PATCH] fix fat utf8 iocharset warning message

[PATCH] fix fat utf8 iocharset warning message

[Mihai Moldovan]

[-- Attachment #1: Type: text/plain, Size: 915 bytes --]

The fat_msg function already formats the given message and appends
a newline to it - we don't need to do this in the passed message
string as well, or will end up with a blank line printed in the
kernel log ring buffer.

Signed-off-by: Mihai Moldovan <ionic@ionic.de>
Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
---
 fs/fat/inode.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/fat/inode.c b/fs/fat/inode.c
index 5942fec..46530a1 100644
--- a/fs/fat/inode.c
+++ b/fs/fat/inode.c
@@ -1190,7 +1190,7 @@ out:
     if (!strcmp(opts->iocharset, "utf8")) {
         fat_msg(sb, KERN_ERR, "utf8 is not a recommended IO charset"
                " for FAT filesystems, filesystem will be "
-               "case sensitive!\n");
+               "case sensitive!");
     }
 
     /* If user doesn't specify allow_utime, it's initialized from dmask. */
-- 
1.7.6


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4369 bytes --]

Re: [PATCH] fix fat utf8 iocharset warning message

[Jesper Juhl]

On Sun, 24 Jul 2011, Mihai Moldovan wrote:

> The fat_msg function already formats the given message and appends
> a newline to it - we don't need to do this in the passed message
> string as well, or will end up with a blank line printed in the
> kernel log ring buffer.
> 
> Signed-off-by: Mihai Moldovan <ionic@ionic.de>
> Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
> ---
>  fs/fat/inode.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/fat/inode.c b/fs/fat/inode.c
> index 5942fec..46530a1 100644
> --- a/fs/fat/inode.c
> +++ b/fs/fat/inode.c
> @@ -1190,7 +1190,7 @@ out:
>      if (!strcmp(opts->iocharset, "utf8")) {
>          fat_msg(sb, KERN_ERR, "utf8 is not a recommended IO charset"

Is KERN_ERR really the right thing to use here? 
Sounds more like a warning to me..


>                 " for FAT filesystems, filesystem will be "
> -               "case sensitive!\n");
> +               "case sensitive!");
>      }
>  
>      /* If user doesn't specify allow_utime, it's initialized from dmask. */
> 

-- 
Jesper Juhl <jj@chaosbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

Re: [PATCH] fix fat utf8 iocharset warning message

[Mihai Moldovan]

[-- Attachment #1: Type: text/plain, Size: 393 bytes --]

* On 24.07.2011 07:22 PM, Jesper Juhl wrote:
> @@ -1190,7 +1190,7 @@ out:
>      if (!strcmp(opts->iocharset, "utf8")) {
>          fat_msg(sb, KERN_ERR, "utf8 is not a recommended IO charset"
> Is KERN_ERR really the right thing to use here? 
> Sounds more like a warning to me..

I'm interested to see what Ogawa says, but I'd say KERN_WARNING would be
better here as well, yeah.


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4369 bytes --]

Re: [PATCH] fix fat utf8 iocharset warning message

[OGAWA Hirofumi]

Mihai Moldovan <ionic@ionic.de> writes:

> * On 24.07.2011 07:22 PM, Jesper Juhl wrote:
>> @@ -1190,7 +1190,7 @@ out:
>>      if (!strcmp(opts->iocharset, "utf8")) {
>>          fat_msg(sb, KERN_ERR, "utf8 is not a recommended IO charset"
>> Is KERN_ERR really the right thing to use here? 
>> Sounds more like a warning to me..
>
> I'm interested to see what Ogawa says, but I'd say KERN_WARNING would be
> better here as well, yeah.

I agree to change it.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>