[bisected regression] Partial breakage of forcedeth driver

[bisected regression] Partial breakage of forcedeth driver

[walt]

Hi gang.

commit 3326c784c9f492e988617d93f647ae0cfd4c8d09
Author: Jiri Pirko <jpirko@>
Date:   Wed Jul 20 04:54:38 2011 +0000

    forcedeth: do vlan cleanup
    
    - unify vlan and nonvlan rx path
    - kill np->vlangrp and nv_vlan_rx_register
    - allow to turn on/off rx vlan accel via ethtool (set_features)
    
    Signed-off-by: Jiri Pirko <jpirko@>
    Signed-off-by: David S. Miller <davem@>

This commit causes networking trouble for my nForce-based motherboard.
(Details happily supplied if needed.)

I say 'partial' breakage because networking is not completely dead,
just limping very slowly :)

The simplest test is to ping any host (in my LAN or on the internet,
makes no difference).  The replies to my ping come at very irregular
intervals, ranging from normal to 5-10 seconds or so, seemingly at
random AFAICT.

I'm happy to try any patches, tests, whatever, to help fix this.

Many thanks!

Re: [bisected regression] Partial breakage of forcedeth driver

[john stultz]

On Sun, Jul 24, 2011 at 4:10 PM, walt <w41ter@gmail.com> wrote:
> commit 3326c784c9f492e988617d93f647ae0cfd4c8d09
> Author: Jiri Pirko <jpirko@>
> Date:   Wed Jul 20 04:54:38 2011 +0000
>
>    forcedeth: do vlan cleanup
>
>    - unify vlan and nonvlan rx path
>    - kill np->vlangrp and nv_vlan_rx_register
>    - allow to turn on/off rx vlan accel via ethtool (set_features)
>
>    Signed-off-by: Jiri Pirko <jpirko@>
>    Signed-off-by: David S. Miller <davem@>
>
> This commit causes networking trouble for my nForce-based motherboard.
> (Details happily supplied if needed.)
>
> I say 'partial' breakage because networking is not completely dead,
> just limping very slowly :)
>
> The simplest test is to ping any host (in my LAN or on the internet,
> makes no difference).  The replies to my ping come at very irregular
> intervals, ranging from normal to 5-10 seconds or so, seemingly at
> random AFAICT.

I'm seeing this too.  Ping responses phase in and out every 10 seconds or so.

Jiri, any thoughts?

thanks
-john

Re: [bisected regression] Partial breakage of forcedeth driver

[Mike Sampson]

On Tue, Jul 26, 2011 at 9:23 AM, john stultz <johnstul@us.ibm.com> wrote:
> On Sun, Jul 24, 2011 at 4:10 PM, walt <w41ter@gmail.com> wrote:
>> commit 3326c784c9f492e988617d93f647ae0cfd4c8d09
>> Author: Jiri Pirko <jpirko@>
>> Date:   Wed Jul 20 04:54:38 2011 +0000
>>
>>    forcedeth: do vlan cleanup
>>
>>    - unify vlan and nonvlan rx path
>>    - kill np->vlangrp and nv_vlan_rx_register
>>    - allow to turn on/off rx vlan accel via ethtool (set_features)
>>
>>    Signed-off-by: Jiri Pirko <jpirko@>
>>    Signed-off-by: David S. Miller <davem@>
>>
>> This commit causes networking trouble for my nForce-based motherboard.
>> (Details happily supplied if needed.)
>>
>> I say 'partial' breakage because networking is not completely dead,
>> just limping very slowly :)
>>
>> The simplest test is to ping any host (in my LAN or on the internet,
>> makes no difference).  The replies to my ping come at very irregular
>> intervals, ranging from normal to 5-10 seconds or so, seemingly at
>> random AFAICT.
>
> I'm seeing this too.  Ping responses phase in and out every 10 seconds or so.
>
[snip]

I am seeing similar here. Pings are often being dropped all together
and the network is unusable. Mainboard is an ASUS M2N with NVIDIA
nForce 430 MCP chipset.

Regards,

Mike

Re: [bisected regression] Partial breakage of forcedeth driver

[Jiri Pirko]

Tue, Jul 26, 2011 at 01:23:59AM CEST, johnstul@us.ibm.com wrote:
>On Sun, Jul 24, 2011 at 4:10 PM, walt <w41ter@gmail.com> wrote:
>> commit 3326c784c9f492e988617d93f647ae0cfd4c8d09
>> Author: Jiri Pirko <jpirko@>
>> Date:   Wed Jul 20 04:54:38 2011 +0000
>>
>>    forcedeth: do vlan cleanup
>>
>>    - unify vlan and nonvlan rx path
>>    - kill np->vlangrp and nv_vlan_rx_register
>>    - allow to turn on/off rx vlan accel via ethtool (set_features)
>>
>>    Signed-off-by: Jiri Pirko <jpirko@>
>>    Signed-off-by: David S. Miller <davem@>
>>
>> This commit causes networking trouble for my nForce-based motherboard.
>> (Details happily supplied if needed.)
>>
>> I say 'partial' breakage because networking is not completely dead,
>> just limping very slowly :)
>>
>> The simplest test is to ping any host (in my LAN or on the internet,
>> makes no difference).  The replies to my ping come at very irregular
>> intervals, ranging from normal to 5-10 seconds or so, seemingly at
>> random AFAICT.
>
>I'm seeing this too.  Ping responses phase in and out every 10 seconds or so.
>
>Jiri, any thoughts?

Nothing so far. I plan to take a loot at this today. Will keep you guyes
posted.

Jirka

>
>thanks
>-john

Re: [bisected regression] Partial breakage of forcedeth driver

[Jiri Pirko]

Tue, Jul 26, 2011 at 08:35:11AM CEST, jpirko@redhat.com wrote:
>Tue, Jul 26, 2011 at 01:23:59AM CEST, johnstul@us.ibm.com wrote:
>>On Sun, Jul 24, 2011 at 4:10 PM, walt <w41ter@gmail.com> wrote:
>>> commit 3326c784c9f492e988617d93f647ae0cfd4c8d09
>>> Author: Jiri Pirko <jpirko@>
>>> Date:   Wed Jul 20 04:54:38 2011 +0000
>>>
>>>    forcedeth: do vlan cleanup
>>>
>>>    - unify vlan and nonvlan rx path
>>>    - kill np->vlangrp and nv_vlan_rx_register
>>>    - allow to turn on/off rx vlan accel via ethtool (set_features)
>>>
>>>    Signed-off-by: Jiri Pirko <jpirko@>
>>>    Signed-off-by: David S. Miller <davem@>
>>>
>>> This commit causes networking trouble for my nForce-based motherboard.
>>> (Details happily supplied if needed.)
>>>
>>> I say 'partial' breakage because networking is not completely dead,
>>> just limping very slowly :)
>>>
>>> The simplest test is to ping any host (in my LAN or on the internet,
>>> makes no difference).  The replies to my ping come at very irregular
>>> intervals, ranging from normal to 5-10 seconds or so, seemingly at
>>> random AFAICT.
>>
>>I'm seeing this too.  Ping responses phase in and out every 10 seconds or so.
>>
>>Jiri, any thoughts?
>
>Nothing so far. I plan to take a loot at this today. Will keep you guyes
>posted.

Will post patch soon.

>
>Jirka
>
>>
>>thanks
>>-john
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/

Re: [bisected regression] Partial breakage of forcedeth driver

[Maciej Rutecki]

On poniedziałek, 25 lipca 2011 o 01:10:59 walt wrote:
> Hi gang.
> 
> commit 3326c784c9f492e988617d93f647ae0cfd4c8d09
> Author: Jiri Pirko <jpirko@>
> Date:   Wed Jul 20 04:54:38 2011 +0000
> 
>     forcedeth: do vlan cleanup
> 
>     - unify vlan and nonvlan rx path
>     - kill np->vlangrp and nv_vlan_rx_register
>     - allow to turn on/off rx vlan accel via ethtool (set_features)
> 
>     Signed-off-by: Jiri Pirko <jpirko@>
>     Signed-off-by: David S. Miller <davem@>
> 
> This commit causes networking trouble for my nForce-based motherboard.
> (Details happily supplied if needed.)
> 

[...]
I created a Bugzilla entry at 
https://bugzilla.kernel.org/show_bug.cgi?id=40272
for your bug report, please add your address to the CC list in there, thanks!

-- 
Maciej Rutecki
http://www.maciek.unixy.pl

Re: [bisected regression] Partial breakage of forcedeth driver

[David Miller]

From: Maciej Rutecki <maciej.rutecki@gmail.com>
Date: Thu, 28 Jul 2011 15:41:08 +0200

> On poniedziałek, 25 lipca 2011 o 01:10:59 walt wrote:
>> Hi gang.
>> 
>> commit 3326c784c9f492e988617d93f647ae0cfd4c8d09
>> Author: Jiri Pirko <jpirko@>
>> Date:   Wed Jul 20 04:54:38 2011 +0000
>> 
>>     forcedeth: do vlan cleanup
>> 
>>     - unify vlan and nonvlan rx path
>>     - kill np->vlangrp and nv_vlan_rx_register
>>     - allow to turn on/off rx vlan accel via ethtool (set_features)
>> 
>>     Signed-off-by: Jiri Pirko <jpirko@>
>>     Signed-off-by: David S. Miller <davem@>
>> 
>> This commit causes networking trouble for my nForce-based motherboard.
>> (Details happily supplied if needed.)
>> 
> 
> [...]
> I created a Bugzilla entry at 
> https://bugzilla.kernel.org/show_bug.cgi?id=40272
> for your bug report, please add your address to the CC list in there, thanks!

It's fixed already in Linus's tree as of a few minuts ago.

Re: [bisected regression] Partial breakage of forcedeth driver

[Maciej Rutecki]

On czwartek, 28 lipca 2011 o 15:42:45 David Miller wrote:
> From: Maciej Rutecki <maciej.rutecki@gmail.com>
> Date: Thu, 28 Jul 2011 15:41:08 +0200
> 
> > On poniedziałek, 25 lipca 2011 o 01:10:59 walt wrote:
> >> Hi gang.
> >> 
> >> commit 3326c784c9f492e988617d93f647ae0cfd4c8d09
> >> Author: Jiri Pirko <jpirko@>
> >> Date:   Wed Jul 20 04:54:38 2011 +0000
> >> 
> >>     forcedeth: do vlan cleanup
> >>     
> >>     - unify vlan and nonvlan rx path
> >>     - kill np->vlangrp and nv_vlan_rx_register
> >>     - allow to turn on/off rx vlan accel via ethtool (set_features)
> >>     
> >>     Signed-off-by: Jiri Pirko <jpirko@>
> >>     Signed-off-by: David S. Miller <davem@>
> >> 
> >> This commit causes networking trouble for my nForce-based motherboard.
> >> (Details happily supplied if needed.)
> > 
> > [...]
> > I created a Bugzilla entry at
> > https://bugzilla.kernel.org/show_bug.cgi?id=40272
> > for your bug report, please add your address to the CC list in there,
> > thanks!
> 
> It's fixed already in Linus's tree as of a few minuts ago.

Thanks. Closing bug.

Regards
-- 
Maciej Rutecki
http://www.maciek.unixy.pl