From: Ryan Mallon <rmallon@gmail.com>
To: Jesper Juhl <jj@chaosbits.net>
Cc: linux-kernel@vger.kernel.org, Alan Cox <alan@linux.intel.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
devel@driverdev.osuosl.org
Subject: Re: GMA500: ERROR: "__bad_udelay" undefined!
Date: Mon, 25 Jul 2011 11:22:35 +1000 [thread overview]
Message-ID: <4E2CC55B.5010307@gmail.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1107242327030.7103@swampdragon.chaosbits.net>
On 25/07/11 07:37, Jesper Juhl wrote:
> Just got this when building the attached .config on x86_64 with gcc 4.6.1
> on up-to-date mainline git tree (head at
> b6844e8f64920cdee620157252169ba63afb0c89) :
>
> ERROR: "__bad_udelay" [drivers/staging/gma500/psb_gfx.ko] undefined!
> make[1]: *** [__modpost] Error 1
>
> I don't need gma500, so I've just disabled the driver to get around it but
> I thought some people might still like to know :)
>
__bad_udelay is a compile time check that constant udelays do not exceed
a certain threshold. For x86_64 it used to be n > 20000, now it is n /
20000 >= 1. The problem is in
drivers/staging/gma500/psb_intel_display.c:psb_init_wait_for_vblank,
which does udelay(20000) which under the old code would have been fine,
but fails the new __bad_udelay check.
Possibly the udelay can just be converted to an mdelay?
~Ryan
next prev parent reply other threads:[~2011-07-25 1:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-24 21:37 GMA500: ERROR: "__bad_udelay" undefined! Jesper Juhl
2011-07-25 1:22 ` Ryan Mallon [this message]
2011-07-25 1:28 ` Ryan Mallon
2011-07-25 2:15 ` Arnaud Lacombe
2011-07-25 21:08 ` Arnd Bergmann
2011-07-25 21:42 ` Alan Cox
2011-07-26 9:06 ` Patrik Jakobsson
2011-07-26 10:19 ` Alan Cox
2011-07-26 14:07 ` Patrik Jakobsson
2011-07-26 15:07 ` Alan Cox
2011-08-01 1:54 ` Patrik Jakobsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2CC55B.5010307@gmail.com \
--to=rmallon@gmail.com \
--cc=alan@linux.intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=jj@chaosbits.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox