Re: [GIT PULL] Native Linux KVM tool for 3.1

Alexander Graf
2011-07-25T12:52:07Z

On 25.07.2011, at 14:47, Avi Kivity wrote:

> On 07/25/2011 03:45 PM, Pekka Enberg wrote:
>> On Mon, Jul 25, 2011 at 12:06 PM, Alexander Graf<agraf@suse.de> wrote:
>> >> And don't get this the wrong way either, I'm not hostile against other
>> >> operating systems, but I simply am not interested enough in them to
>> >> spend my time improving them.
>> >
>> > Then kvm-tool is about as useful as Mac-on-Linux. Why don't we have MoL user land in the kernel? I even added support for KVM to it about a year ago. So all I need to do is change it to the kernel coding style, add some dependencies on kernel headers and I'm good for a pull request?
>>
>> Oh, I dunno - have you tried that? If you're interested in sending a
>> patch against tools/kvm that adds KVM-based support to Mac, I'm happy
>> to review it and consider for inclusion. ;-)
>
> The patch will be a lot bigger than tools/kvm itself.

And it will be full of ugly hacks and code that needs to be compiled on a Mac. I was actually trying to pick an example of a project that you really don't want to have in the kernel tree.

One point stays true however with MoL. I added support for KVM a year ago and haven't had to touch it since. It just works. Because we have a pretty stable kernel/user space interface. So the whole thing about having user space and kernel code live together in the same tree is moot there.

And if you need to share code with perf, then that just proves the point that perf doesn't belong inside the kernel tree either.

Alex