From: Andy Grover <agrover@redhat.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
target-devel <target-devel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.de>,
Roland Dreier <roland@purestorage.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Boaz Harrosh <openosd@gmail.com>,
Mike Christie <michaelc@cs.wisc.edu>
Subject: Re: [GIT PULL] iscsi-target merge for v3.1-rc1
Date: Mon, 25 Jul 2011 18:09:18 -0700 [thread overview]
Message-ID: <4E2E13BE.7000909@redhat.com> (raw)
In-Reply-To: <1311640376.17766.221.camel@haakon2.linux-iscsi.org>
On 07/25/2011 05:32 PM, Nicholas A. Bellinger wrote:
> On Mon, 2011-07-25 at 16:37 -0700, Andrew Morton wrote:
>> On Sat, 23 Jul 2011 16:16:15 -0700
>> "Nicholas A. Bellinger" <nab@linux-iscsi.org> wrote:
>>
>>> Please go ahead and pull from:
>>>
>>> master.kernel.org:/pub/scm/linux/kernel/git/nab/target-pending.git for-linus-merge
>>
>> i386 allyesconfig:
>>
>> ERROR: "__udivdi3" [drivers/target/target_core_mod.ko] undefined!
>>
>> somewhere in drivers/target/target_core_transport.c:transport_allocate_data_tasks().
>
> Mmmm, I was under the assumption that DIV_ROUND_UP() did unsigned long
> long division correctly for sector_t on 32-bit , but apparently not with
> the new v4.1 transport_allocate_data_tasks() code.. Andy..?
sectors = DIV_ROUND_UP(cmd->data_length, sector_size);
task_count = DIV_ROUND_UP(sectors, dev_max_sectors);
sectors is a sector_t but the value will never be >32bits, since
data_length is u32.
We could just cast sectors to a u32 and be ok for this particular
usage... DIV_ROUND_UP handling 64bit would of course also resolve the
issue nicely.
Regards -- Andy
prev parent reply other threads:[~2011-07-26 1:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-23 23:16 [GIT PULL] iscsi-target merge for v3.1-rc1 Nicholas A. Bellinger
2011-07-23 23:33 ` Andrew Morton
2011-07-24 0:19 ` Nicholas A. Bellinger
2011-07-24 2:27 ` Stephen Rothwell
2011-07-25 23:37 ` Andrew Morton
2011-07-25 23:46 ` Linus Torvalds
2011-07-25 23:52 ` Andrew Morton
2011-07-25 23:50 ` Andrew Morton
2011-07-26 6:51 ` Nicholas A. Bellinger
2011-07-26 7:09 ` Linus Torvalds
2011-07-26 7:26 ` Nicholas A. Bellinger
2011-07-26 7:43 ` Andrew Morton
2011-07-26 7:51 ` Nicholas A. Bellinger
2011-07-26 10:08 ` Olivier Galibert
2011-07-26 10:14 ` Alexey Dobriyan
2011-07-26 0:32 ` Nicholas A. Bellinger
2011-07-26 1:09 ` Andy Grover [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2E13BE.7000909@redhat.com \
--to=agrover@redhat.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=nab@linux-iscsi.org \
--cc=openosd@gmail.com \
--cc=roland@purestorage.com \
--cc=target-devel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox