[PATCH 1/1] Staging: comedi: fix printk issue in c6xdigio.c

public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed

* [PATCH 1/1] Staging: comedi: fix printk issue in c6xdigio.c
       [not found] <[PATCH]Staging: comedi: fix printk issue in c6xdigio.c>
@ 2011-07-26  5:27 ` Ravishankar
  2011-07-26  5:27   ` Joe Perches
  2011-07-26  6:45 ` [PATCH 1/1 v2] " Ravishankar
  1 sibling, 1 reply; 4+ messages in thread
From: Ravishankar @ 2011-07-26  5:27 UTC (permalink / raw)
  To: gregkh, wfp5p; +Cc: devel, linux-kernel, Ravishankar, Ravishankr

From: Ravishankar <ravi.shankar@greenturtles.in>

This is a patch to the c6xdigio.c file that fixes up a printk warning found by the checkpatch.pl tool

Signed-off-by: Ravishankr <ravishankarkm32@gmail.com>
---
 drivers/staging/comedi/drivers/c6xdigio.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/comedi/drivers/c6xdigio.c b/drivers/staging/comedi/drivers/c6xdigio.c
index e0ac825..b0b578c 100644
--- a/drivers/staging/comedi/drivers/c6xdigio.c
+++ b/drivers/staging/comedi/drivers/c6xdigio.c
@@ -343,7 +343,7 @@ static int c6xdigio_pwmo_insn_read(struct comedi_device *dev,
 				   struct comedi_subdevice *s,
 				   struct comedi_insn *insn, unsigned int *data)
 {
-	printk("c6xdigio_pwmo_insn_read %x\n", insn->n);
+	pr_info("c6xdigio_pwmo_insn_read %x\n", insn->n);
 	return insn->n;
 }
 
@@ -439,9 +439,9 @@ static int c6xdigio_attach(struct comedi_device *dev,
 	struct comedi_subdevice *s;
 
 	iobase = it->options[0];
-	printk("comedi%d: c6xdigio: 0x%04lx\n", dev->minor, iobase);
+	pr_info("comedi%d: c6xdigio: 0x%04lx\n", dev->minor, iobase);
 	if (!request_region(iobase, C6XDIGIO_SIZE, "c6xdigio")) {
-		printk("comedi%d: I/O port conflict\n", dev->minor);
+		pr_err("comedi%d: I/O port conflict\n", dev->minor);
 		return -EIO;
 	}
 	dev->iobase = iobase;
@@ -456,9 +456,9 @@ static int c6xdigio_attach(struct comedi_device *dev,
 
 	irq = it->options[1];
 	if (irq > 0)
-		printk("comedi%d: irq = %u ignored\n", dev->minor, irq);
+		pr_debug("comedi%d: irq = %u ignored\n", dev->minor, irq);
 	else if (irq == 0)
-		printk("comedi%d: no irq\n", dev->minor);
+		pr_debug("comedi%d: no irq\n", dev->minor);
 
 	s = dev->subdevices + 0;
 	/* pwm output subdevice */
@@ -503,7 +503,7 @@ static int c6xdigio_detach(struct comedi_device *dev)
 {
 	/* board_halt(dev);  may not need this */
 
-	printk("comedi%d: c6xdigio: remove\n", dev->minor);
+	pr_info("comedi%d: c6xdigio: remove\n", dev->minor);
 
 	if (dev->iobase)
 		release_region(dev->iobase, C6XDIGIO_SIZE);
-- 
1.6.5.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] Staging: comedi: fix printk issue in c6xdigio.c
  2011-07-26  5:27 ` [PATCH 1/1] Staging: comedi: fix printk issue in c6xdigio.c Ravishankar
@ 2011-07-26  5:27   ` Joe Perches
  0 siblings, 0 replies; 4+ messages in thread
From: Joe Perches @ 2011-07-26  5:27 UTC (permalink / raw)
  To: Ravishankar; +Cc: gregkh, wfp5p, devel, linux-kernel, Ravishankar

On Tue, 2011-07-26 at 10:57 +0530, Ravishankar wrote:
> This is a patch to the c6xdigio.c file that fixes up a printk warning found by the checkpatch.pl tool
> diff --git a/drivers/staging/comedi/drivers/c6xdigio.c b/drivers/staging/comedi/drivers/c6xdigio.c
[]
> @@ -343,7 +343,7 @@ static int c6xdigio_pwmo_insn_read(struct comedi_device *dev,
[]
> -	printk("c6xdigio_pwmo_insn_read %x\n", insn->n);
> +	pr_info("c6xdigio_pwmo_insn_read %x\n", insn->n);

It would be good if you would convert embedded function names
to "%s", __func__.  Maybe convert the bare printks to appropriate
levels as well.  Perhaps:

	pr_debug("%s: %x\n", __func__, insn->n);



^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/1 v2] Staging: comedi: fix printk issue in c6xdigio.c
       [not found] <[PATCH]Staging: comedi: fix printk issue in c6xdigio.c>
  2011-07-26  5:27 ` [PATCH 1/1] Staging: comedi: fix printk issue in c6xdigio.c Ravishankar
@ 2011-07-26  6:45 ` Ravishankar
  2011-07-26  6:41   ` Ryan Mallon
  1 sibling, 1 reply; 4+ messages in thread
From: Ravishankar @ 2011-07-26  6:45 UTC (permalink / raw)
  To: gregkh, wfp5p; +Cc: devel, linux-kernel, Ravishankar, Ravishankr

From: Ravishankar <ravi.shankar@greenturtles.in>

This is a patch to the c6xdigio.c file that fixes up a printk warning found by the checkpatch.pl tool

Signed-off-by: Ravishankr <ravishankarkm32@gmail.com>
---

 drivers/staging/comedi/drivers/c6xdigio.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/comedi/drivers/c6xdigio.c b/drivers/staging/comedi/drivers/c6xdigio.c
index e0ac825..b0b578c 100644
--- a/drivers/staging/comedi/drivers/c6xdigio.c
+++ b/drivers/staging/comedi/drivers/c6xdigio.c
@@ -343,7 +343,7 @@ static int c6xdigio_pwmo_insn_read(struct comedi_device *dev,
 				   struct comedi_subdevice *s,
 				   struct comedi_insn *insn, unsigned int *data)
 {
-	printk("c6xdigio_pwmo_insn_read %x\n", insn->n);
+	pr_info("%s %x\n", __func__, insn->n);
 	return insn->n;
 }
 
@@ -439,9 +439,9 @@ static int c6xdigio_attach(struct comedi_device *dev,
 	struct comedi_subdevice *s;
 
 	iobase = it->options[0];
-	printk("comedi%d: c6xdigio: 0x%04lx\n", dev->minor, iobase);
+	pr_info("comedi%d: c6xdigio: 0x%04lx\n", dev->minor, iobase);
 	if (!request_region(iobase, C6XDIGIO_SIZE, "c6xdigio")) {
-		printk("comedi%d: I/O port conflict\n", dev->minor);
+		pr_err("comedi%d: I/O port conflict\n", dev->minor);
 		return -EIO;
 	}
 	dev->iobase = iobase;
@@ -456,9 +456,9 @@ static int c6xdigio_attach(struct comedi_device *dev,
 
 	irq = it->options[1];
 	if (irq > 0)
-		printk("comedi%d: irq = %u ignored\n", dev->minor, irq);
+		pr_debug("%s: %x\n", __func__, insn->n);
 	else if (irq == 0)
-		printk("comedi%d: no irq\n", dev->minor);
+		pr_debug("%s: %x\n", __func__, insn->n);
 
 	s = dev->subdevices + 0;
 	/* pwm output subdevice */
@@ -503,7 +503,7 @@ static int c6xdigio_detach(struct comedi_device *dev)
 {
 	/* board_halt(dev);  may not need this */
 
-	printk("comedi%d: c6xdigio: remove\n", dev->minor);
+	pr_info("comedi%d: c6xdigio: remove\n", dev->minor);
 
 	if (dev->iobase)
 		release_region(dev->iobase, C6XDIGIO_SIZE);
-- 
1.6.5.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1 v2] Staging: comedi: fix printk issue in c6xdigio.c
  2011-07-26  6:45 ` [PATCH 1/1 v2] " Ravishankar
@ 2011-07-26  6:41   ` Ryan Mallon
  0 siblings, 0 replies; 4+ messages in thread
From: Ryan Mallon @ 2011-07-26  6:41 UTC (permalink / raw)
  To: Ravishankar; +Cc: gregkh, wfp5p, devel, linux-kernel, Ravishankar

On 26/07/11 16:45, Ravishankar wrote:
> From: Ravishankar<ravi.shankar@greenturtles.in>
>
> This is a patch to the c6xdigio.c file that fixes up a printk warning found by the checkpatch.pl tool
>
> Signed-off-by: Ravishankr<ravishankarkm32@gmail.com>
> ---
>
>   drivers/staging/comedi/drivers/c6xdigio.c |   12 ++++++------
>   1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/c6xdigio.c b/drivers/staging/comedi/drivers/c6xdigio.c
> index e0ac825..b0b578c 100644
> --- a/drivers/staging/comedi/drivers/c6xdigio.c
> +++ b/drivers/staging/comedi/drivers/c6xdigio.c
> @@ -343,7 +343,7 @@ static int c6xdigio_pwmo_insn_read(struct comedi_device *dev,
>   				   struct comedi_subdevice *s,
>   				   struct comedi_insn *insn, unsigned int *data)
>   {
> -	printk("c6xdigio_pwmo_insn_read %x\n", insn->n);
> +	pr_info("%s %x\n", __func__, insn->n);
>   	return insn->n;
>   }
>
> @@ -439,9 +439,9 @@ static int c6xdigio_attach(struct comedi_device *dev,
>   	struct comedi_subdevice *s;
>
>   	iobase = it->options[0];
> -	printk("comedi%d: c6xdigio: 0x%04lx\n", dev->minor, iobase);
> +	pr_info("comedi%d: c6xdigio: 0x%04lx\n", dev->minor, iobase);
>   	if (!request_region(iobase, C6XDIGIO_SIZE, "c6xdigio")) {
> -		printk("comedi%d: I/O port conflict\n", dev->minor);
> +		pr_err("comedi%d: I/O port conflict\n", dev->minor);
>   		return -EIO;
>   	}
>   	dev->iobase = iobase;
> @@ -456,9 +456,9 @@ static int c6xdigio_attach(struct comedi_device *dev,
>
>   	irq = it->options[1];
>   	if (irq>  0)
> -		printk("comedi%d: irq = %u ignored\n", dev->minor, irq);
> +		pr_debug("%s: %x\n", __func__, insn->n);
>   	else if (irq == 0)
> -		printk("comedi%d: no irq\n", dev->minor);
> +		pr_debug("%s: %x\n", __func__, insn->n);

You are doing this without any thought at all. Not only does this 
replace a useful message with a completely useless one, but it also 
won't even compile if DEBUG is defined. It is not confidence inspiring.

~Ryan


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-07-26  6:41 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <[PATCH]Staging: comedi: fix printk issue in c6xdigio.c>
2011-07-26  5:27 ` [PATCH 1/1] Staging: comedi: fix printk issue in c6xdigio.c Ravishankar
2011-07-26  5:27   ` Joe Perches
2011-07-26  6:45 ` [PATCH 1/1 v2] " Ravishankar
2011-07-26  6:41   ` Ryan Mallon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox