public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Justin P. Mattock" <justinmattock@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: trivial@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]Remove extra semicolon's in the kernel.
Date: Tue, 26 Jul 2011 21:09:51 -0700	[thread overview]
Message-ID: <4E2F8F8F.7060106@gmail.com> (raw)
In-Reply-To: <m2zkk0q1ex.fsf@igel.home>


>> diff --git a/arch/ia64/include/asm/mca_asm.h b/arch/ia64/include/asm/mca_asm.h
>> index dd2a5b1..d57d3c0 100644
>> --- a/arch/ia64/include/asm/mca_asm.h
>> +++ b/arch/ia64/include/asm/mca_asm.h
>> @@ -46,11 +46,11 @@
>>    *	1. Put 0x7 in bits 61 thru 63.
>>    */
>>   #define DATA_PA_TO_VA(addr,temp)							\
>> -	mov	temp	= 0x7	;;							\
>> +	mov	temp	= 0x7;							\
>
> Double semicolons are significant in the ia64 assembler language.

appologize for the delay(have this thing called work!)
anyways:

ahh.. I was confused if one semicolon should be used, or two(some say 
yes, some say no etc..) and now I know for the ia64 two is used.
(thanks for the info on this)

>
>> diff --git a/scripts/setlocalversion b/scripts/setlocalversion
>> index 4d40384..e187f1f 100755
>> --- a/scripts/setlocalversion
>> +++ b/scripts/setlocalversion
>> @@ -101,7 +101,7 @@ scm_version()
>>   		# Are there uncommitted changes?
>>   		# These are represented by + after the changeset id.
>>   		case "$hgid" in
>> -			*+|*+\ *) printf '%s' -dirty ;;
>> +			*+|*+\ *) printf '%s' -dirty;
>
> Double semicolons are significant in the Bourne shell language.
>

I was torn on what to do with this. part of me said yeah it should stay, 
but then another part of me, said well maybe it was a mistake due to the 
whitespace(so I sent it out).

I will resend without the above, if there is any others let me know, and 
thank you for the help/info

> Andreas.
>


      reply	other threads:[~2011-07-27  4:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-26 18:26 [PATCH]Remove extra semicolon's in the kernel Justin P. Mattock
2011-07-26 19:36 ` Andreas Schwab
2011-07-27  4:09   ` Justin P. Mattock [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E2F8F8F.7060106@gmail.com \
    --to=justinmattock@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwab@linux-m68k.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox