From: Michal Marek <mmarek@suse.cz>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: "Arnaud Lacombe" <lacombar@gmail.com>,
"Américo Wang" <xiyou.wangcong@gmail.com>,
linux-kbuild@vger.kernel.org, sam@ravnborg.org,
linux-kernel@vger.kernel.org, plagnioj@jcrosoft.com
Subject: Re: [RFC][PATCH 1/2] kconfig: Introduce KCONFIG(), KCONFIG_BUILTIN() and KCONFIG_MODULE()
Date: Wed, 27 Jul 2011 10:36:58 +0200 [thread overview]
Message-ID: <4E2FCE2A.3000909@suse.cz> (raw)
In-Reply-To: <20110726213536.1f56f0e3.rdunlap@xenotime.net>
On 27.7.2011 06:35, Randy Dunlap wrote:
> On Tue, 26 Jul 2011 20:42:04 -0400 Arnaud Lacombe wrote:
>> On Tue, Jul 26, 2011 at 2:48 PM, Arnaud Lacombe<lacombar@gmail.com> wrote:
>>> On Tue, Jul 26, 2011 at 2:28 PM, Randy Dunlap<rdunlap@xenotime.net> wrote:
>>>> I guess I prefer your ENABLED() syntax then.
>>>>
>>> we need to be careful about namespace pollution/collision.
>>>
>> For the sake of having numbers:
>>
>> % git grep -w ENABLED . | wc -l
>> 116
>> % git grep -w CONFIGURED . | wc -l
>> 11
>> % git grep -w KCONFIG . | wc -l
>> 1
>
> OK. Then I would go back to a predicate like the original patch had,
> e.g.:
> IS_ENABLED(CONFIG_NUMA)
Good idea. Is anyone against
IS_ENABLED(CONFIG_FOO)
IS_ENABLED_BUILTIN(CONFIG_FOO)
IS_ENABLED_MODULE(CONFIG_FOO)
?
Michal
next prev parent reply other threads:[~2011-07-27 8:37 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 15:35 [PATCH] kconfig: Only generate config_is_xxx for bool and tristate options Michal Marek
2011-05-17 18:05 ` Jean-Christophe PLAGNIOL-VILLARD
2011-05-17 19:44 ` Michal Marek
2011-05-17 19:53 ` Sam Ravnborg
2011-05-18 5:16 ` Jean-Christophe PLAGNIOL-VILLARD
2011-05-18 6:19 ` Sam Ravnborg
2011-05-18 6:27 ` Arnaud Lacombe
2011-05-18 6:23 ` Arnaud Lacombe
2011-07-13 13:22 ` Michal Marek
2011-07-13 15:20 ` Arnaud Lacombe
2011-07-13 20:08 ` Sam Ravnborg
2011-07-19 13:45 ` Michal Marek
2011-07-25 22:58 ` [RFC][PATCH 1/2] kconfig: Introduce KCONFIG(), KCONFIG_BUILTIN() and KCONFIG_MODULE() Michal Marek
2011-07-25 22:58 ` [RFC][PATCH 2/2] mm: Switch NUMA_BUILD and COMPACTION_BUILD to new KCONFIG() syntax Michal Marek
2011-07-26 15:19 ` Michal Hocko
2011-07-26 18:34 ` Michal Marek
2011-07-26 18:52 ` Michal Hocko
2011-07-26 13:01 ` [RFC][PATCH 1/2] kconfig: Introduce KCONFIG(), KCONFIG_BUILTIN() and KCONFIG_MODULE() Américo Wang
2011-07-26 13:21 ` Michal Marek
2011-07-26 15:04 ` Randy Dunlap
2011-07-26 18:28 ` Michal Marek
2011-07-26 18:28 ` Randy Dunlap
2011-07-26 18:48 ` Arnaud Lacombe
2011-07-27 0:42 ` Arnaud Lacombe
2011-07-27 4:35 ` Randy Dunlap
2011-07-27 8:36 ` Michal Marek [this message]
2011-07-27 13:31 ` Arnaud Lacombe
2011-07-27 13:38 ` Michal Marek
2011-07-27 15:11 ` Arnaud Lacombe
2011-07-27 15:18 ` Michal Marek
2011-07-27 16:36 ` Américo Wang
2011-07-27 15:09 ` Arnaud Lacombe
2011-07-27 15:16 ` Michal Marek
2011-07-27 15:18 ` Arnaud Lacombe
2011-07-29 13:51 ` [PATCH] kconfig: Introduce IS_ENABLED(), IS_BUILTIN() and IS_MODULE() Michal Marek
2011-07-29 17:43 ` Arnaud Lacombe
2011-07-29 18:25 ` Randy Dunlap
2011-07-29 18:58 ` Arnaud Lacombe
2011-08-02 17:33 ` Sam Ravnborg
2011-08-02 17:50 ` Arnaud Lacombe
2011-08-02 19:26 ` Sam Ravnborg
2011-08-02 19:33 ` Michal Marek
2011-08-02 19:33 ` Arnaud Lacombe
2011-05-25 13:35 ` [PATCH] kconfig: Only generate config_is_xxx for bool and tristate options Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2FCE2A.3000909@suse.cz \
--to=mmarek@suse.cz \
--cc=lacombar@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=rdunlap@xenotime.net \
--cc=sam@ravnborg.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).