From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754323Ab1G0Jbc (ORCPT ); Wed, 27 Jul 2011 05:31:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28571 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754022Ab1G0Jba (ORCPT ); Wed, 27 Jul 2011 05:31:30 -0400 Message-ID: <4E2FDAD0.8000809@redhat.com> Date: Wed, 27 Jul 2011 12:30:56 +0300 From: Avi Kivity User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110621 Fedora/3.1.11-1.fc15 Thunderbird/3.1.11 MIME-Version: 1.0 To: Ingo Molnar CC: Borislav Petkov , "Przywara, Andre" , "H. Peter Anvin" , Thomas Gleixner , LKML , "Pohlack, Martin" Subject: Re: [PATCH] x86, AMD: Correct F15h IC aliasing issue References: <1311340547-7861-1-git-send-email-bp@amd64.org> <4E2F0068.1080001@redhat.com> <20110726181304.GD32536@aftab> <4E2F0498.8050005@zytor.com> <20110726183721.GF32536@aftab> <4E2F09BB.9060605@zytor.com> <4E2F1889.8030708@amd.com> <4E2F90A2.4030409@redhat.com> <20110727062120.GA5272@aftab> <20110727065932.GA16555@elte.hu> In-Reply-To: <20110727065932.GA16555@elte.hu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/27/2011 09:59 AM, Ingo Molnar wrote: > > > > Yeah, actually the idea is to patch the kernel only this one time > > and never ever be needing to do this for future CPUs, for this > > matter. > > But the check you have added turns this workaround on for all family > 0x15 CPUs. If a family 0x15 CPU is built with a larger or more > associative cache, one that does not need the workaround, we would > still turn on the workaround. Similarly, if family 0x21 CPUs have a similar arrangement (with identical or different cache sizes and associativity) the hardcoded check will fail. -- error compiling committee.c: too many arguments to function