public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: gmail <teawater@gmail.com>
To: Andy Whitcroft <apw@canonical.com>, linux-kernel@vger.kernel.org
Subject: [PATCH] Fix a argument WARN bug of scripts/checkpatch.pl
Date: Thu, 28 Jul 2011 15:14:12 +0800	[thread overview]
Message-ID: <4E310C44.9050002@gmail.com> (raw)

Sorry the prev patch have the format error.  So I re-send it.

Get following error with a patch that have min_t error:
Use of uninitialized value in concatenation (.) or string at
scripts/checkpatch.pl line 1256.
WARNING:
This is because:
				}
				WARN("$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . $herecurr);
			}
It lost the first argument.
So make a patch to fix it.

Signed-off-by: Hui Zhu <teawater@gmail.com>
---
 scripts/checkpatch.pl |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2574,7 +2574,8 @@ sub process {
 				} else {
 					$cast = $cast2;
 				}
-				WARN("$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . $herecurr);
+				WARN("MINMAX",
+				     "$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . $herecurr);
 			}
 		}
 

             reply	other threads:[~2011-07-28  7:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-28  7:14 gmail [this message]
2011-07-31  0:44 ` [PATCH] Fix a argument WARN bug of scripts/checkpatch.pl Hillf Danton
2011-07-31 15:23   ` Hui Zhu
2011-08-01 12:09 ` Hui Zhu
2011-08-01 15:15   ` Joe Perches
  -- strict thread matches above, loose matches on Subject: below --
2011-08-03  2:36 Hui Zhu
2011-07-28  6:56 Hui Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E310C44.9050002@gmail.com \
    --to=teawater@gmail.com \
    --cc=apw@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox