From: "Daniel Glöckner" <dg@emlix.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
"George G. Davis" <gdavis@mvista.com>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc-omap: Fix initialization of control register
Date: Thu, 28 Jul 2011 11:46:29 +0200 [thread overview]
Message-ID: <4E312FF5.1080007@emlix.com> (raw)
In-Reply-To: <20110727141907.53225270.akpm@linux-foundation.org>
On 07/27/2011 11:19 PM, Andrew Morton wrote:
> On Mon, 11 Jul 2011 12:57:46 +0200
> Daniel Gl__ckner <dg@emlix.com> wrote:
>
>> As the comment explains, the intention of the code is to clear the
>> OMAP_RTC_CTRL_MODE_12_24 bit, but instead it only clears the
>> OMAP_RTC_CTRL_SPLIT and OMAP_RTC_CTRL_AUTO_COMP bits, which should be
>> kept. OMAP_RTC_CTRL_DISABLE, OMAP_RTC_CTRL_SET_32_COUNTER,
>> OMAP_RTC_CTRL_TEST, and OMAP_RTC_CTRL_ROUND_30S are also better off
>> being cleared.
> What were the user-visible effects of the bug?
The contents of the control register is undefined after a complete power
loss. On our board the RTC has been observed to sometimes power up with the
OMAP_RTC_CTRL_SET_32_COUNTER bit being set, which stops the clock.
Daniel
--
Dipl.-Math. Daniel Glöckner, emlix GmbH, http://www.emlix.com
Fon +49 551 30664-0, Fax +49 551 30664-11,
Bertha-von-Suttner-Straße 9, 37085 Göttingen, Germany
Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160
Geschäftsführer: Dr. Uwe Kracke, Ust-IdNr.: DE 205 198 055
emlix - your embedded linux partner
prev parent reply other threads:[~2011-07-28 9:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-11 10:57 [PATCH] rtc-omap: Fix initialization of control register Daniel Glöckner
2011-07-27 21:19 ` Andrew Morton
2011-07-28 9:46 ` Daniel Glöckner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E312FF5.1080007@emlix.com \
--to=dg@emlix.com \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=gdavis@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox