* Re: [PATCH 1/1] mmc: Fixed bug in IDMAC_SET_BUFFER1_SIZE Macro in dw_mmc.c [not found] <1311851023-3563-1-git-send-email-shashidharh@vayavyalabs.com> @ 2011-07-28 11:17 ` James Hogan 2011-07-29 2:17 ` Jaehoon Chung 2011-07-29 10:07 ` Will Newton 0 siblings, 2 replies; 5+ messages in thread From: James Hogan @ 2011-07-28 11:17 UTC (permalink / raw) To: Shashidhar Hiremath; +Cc: Will Newton, Kyungmin Park, linux-mmc, linux-kernel On 07/28/2011 12:03 PM, Shashidhar Hiremath wrote: > The mask used inside this macro was assuming Buffer_Size1's[BS1's] width to be 14 bits, > it is actually of 13 bits, Modified masks used in IDMAC_SET_BUFFER1_SIZE such that > they use only 13 bits instead of current 14. > > Signed-off-by: Shashidhar Hiremath <shashidharh@vayavyalabs.com> > --- > drivers/mmc/host/dw_mmc.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index 77f0b6b..f13bb49 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -62,7 +62,7 @@ struct idmac_desc { > > u32 des1; /* Buffer sizes */ > #define IDMAC_SET_BUFFER1_SIZE(d, s) \ > - ((d)->des1 = ((d)->des1 & 0x03ffc000) | ((s) & 0x3fff)) > + ((d)->des1 = ((d)->des1 & 0x03ffe000) | ((s) & 0x1fff)) > > u32 des2; /* buffer 1 physical address */ > Yes, according to the TRM you appear to be correct Reviewed-by: James Hogan <james.hogan@imgtec.com> Thanks James ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] mmc: Fixed bug in IDMAC_SET_BUFFER1_SIZE Macro in dw_mmc.c 2011-07-28 11:17 ` [PATCH 1/1] mmc: Fixed bug in IDMAC_SET_BUFFER1_SIZE Macro in dw_mmc.c James Hogan @ 2011-07-29 2:17 ` Jaehoon Chung 2011-07-29 6:51 ` Jaehoon Chung 2011-07-29 10:07 ` Will Newton 1 sibling, 1 reply; 5+ messages in thread From: Jaehoon Chung @ 2011-07-29 2:17 UTC (permalink / raw) To: James Hogan Cc: Shashidhar Hiremath, Will Newton, Kyungmin Park, linux-mmc, linux-kernel Hi.. this patch is right. Acked-by : Jaehoon Chung <jh80.chung@samsung.com> Regards, Jaehoon Chung James Hogan wrote: > On 07/28/2011 12:03 PM, Shashidhar Hiremath wrote: >> The mask used inside this macro was assuming Buffer_Size1's[BS1's] width to be 14 bits, >> it is actually of 13 bits, Modified masks used in IDMAC_SET_BUFFER1_SIZE such that >> they use only 13 bits instead of current 14. >> >> Signed-off-by: Shashidhar Hiremath <shashidharh@vayavyalabs.com> >> --- >> drivers/mmc/host/dw_mmc.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c >> index 77f0b6b..f13bb49 100644 >> --- a/drivers/mmc/host/dw_mmc.c >> +++ b/drivers/mmc/host/dw_mmc.c >> @@ -62,7 +62,7 @@ struct idmac_desc { >> >> u32 des1; /* Buffer sizes */ >> #define IDMAC_SET_BUFFER1_SIZE(d, s) \ >> - ((d)->des1 = ((d)->des1 & 0x03ffc000) | ((s) & 0x3fff)) >> + ((d)->des1 = ((d)->des1 & 0x03ffe000) | ((s) & 0x1fff)) >> >> u32 des2; /* buffer 1 physical address */ >> > > Yes, according to the TRM you appear to be correct > > Reviewed-by: James Hogan <james.hogan@imgtec.com> > > Thanks > James > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] mmc: Fixed bug in IDMAC_SET_BUFFER1_SIZE Macro in dw_mmc.c 2011-07-29 2:17 ` Jaehoon Chung @ 2011-07-29 6:51 ` Jaehoon Chung 0 siblings, 0 replies; 5+ messages in thread From: Jaehoon Chung @ 2011-07-29 6:51 UTC (permalink / raw) Cc: James Hogan, Shashidhar Hiremath, Will Newton, Kyungmin Park, linux-mmc, linux-kernel, Chris Ball Just add Chris to CC. Jaehoon Chung wrote: > Hi.. > > this patch is right. > > Acked-by : Jaehoon Chung <jh80.chung@samsung.com> > > Regards, > Jaehoon Chung > > James Hogan wrote: >> On 07/28/2011 12:03 PM, Shashidhar Hiremath wrote: >>> The mask used inside this macro was assuming Buffer_Size1's[BS1's] width to be 14 bits, >>> it is actually of 13 bits, Modified masks used in IDMAC_SET_BUFFER1_SIZE such that >>> they use only 13 bits instead of current 14. >>> >>> Signed-off-by: Shashidhar Hiremath <shashidharh@vayavyalabs.com> >>> --- >>> drivers/mmc/host/dw_mmc.c | 2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c >>> index 77f0b6b..f13bb49 100644 >>> --- a/drivers/mmc/host/dw_mmc.c >>> +++ b/drivers/mmc/host/dw_mmc.c >>> @@ -62,7 +62,7 @@ struct idmac_desc { >>> >>> u32 des1; /* Buffer sizes */ >>> #define IDMAC_SET_BUFFER1_SIZE(d, s) \ >>> - ((d)->des1 = ((d)->des1 & 0x03ffc000) | ((s) & 0x3fff)) >>> + ((d)->des1 = ((d)->des1 & 0x03ffe000) | ((s) & 0x1fff)) >>> >>> u32 des2; /* buffer 1 physical address */ >>> >> Yes, according to the TRM you appear to be correct >> >> Reviewed-by: James Hogan <james.hogan@imgtec.com> >> >> Thanks >> James >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] mmc: Fixed bug in IDMAC_SET_BUFFER1_SIZE Macro in dw_mmc.c 2011-07-28 11:17 ` [PATCH 1/1] mmc: Fixed bug in IDMAC_SET_BUFFER1_SIZE Macro in dw_mmc.c James Hogan 2011-07-29 2:17 ` Jaehoon Chung @ 2011-07-29 10:07 ` Will Newton 2011-07-29 12:53 ` Chris Ball 1 sibling, 1 reply; 5+ messages in thread From: Will Newton @ 2011-07-29 10:07 UTC (permalink / raw) To: James Hogan Cc: Shashidhar Hiremath, Will Newton, Kyungmin Park, linux-mmc, linux-kernel, Chris Ball On Thu, Jul 28, 2011 at 12:17 PM, James Hogan <james.hogan@imgtec.com> wrote: > On 07/28/2011 12:03 PM, Shashidhar Hiremath wrote: >> The mask used inside this macro was assuming Buffer_Size1's[BS1's] width to be 14 bits, >> it is actually of 13 bits, Modified masks used in IDMAC_SET_BUFFER1_SIZE such that >> they use only 13 bits instead of current 14. >> >> Signed-off-by: Shashidhar Hiremath <shashidharh@vayavyalabs.com> >> --- >> drivers/mmc/host/dw_mmc.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c >> index 77f0b6b..f13bb49 100644 >> --- a/drivers/mmc/host/dw_mmc.c >> +++ b/drivers/mmc/host/dw_mmc.c >> @@ -62,7 +62,7 @@ struct idmac_desc { >> >> u32 des1; /* Buffer sizes */ >> #define IDMAC_SET_BUFFER1_SIZE(d, s) \ >> - ((d)->des1 = ((d)->des1 & 0x03ffc000) | ((s) & 0x3fff)) >> + ((d)->des1 = ((d)->des1 & 0x03ffe000) | ((s) & 0x1fff)) >> >> u32 des2; /* buffer 1 physical address */ >> > > Yes, according to the TRM you appear to be correct > > Reviewed-by: James Hogan <james.hogan@imgtec.com> Yes, looks correct to me too (for some reason I didn't get the original mail). Acked-by: Will Newton <will.newton@imgtec.com> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] mmc: Fixed bug in IDMAC_SET_BUFFER1_SIZE Macro in dw_mmc.c 2011-07-29 10:07 ` Will Newton @ 2011-07-29 12:53 ` Chris Ball 0 siblings, 0 replies; 5+ messages in thread From: Chris Ball @ 2011-07-29 12:53 UTC (permalink / raw) To: Will Newton Cc: James Hogan, Shashidhar Hiremath, Will Newton, Kyungmin Park, linux-mmc, linux-kernel Hi Shashidhar, On Fri, Jul 29 2011, Will Newton wrote: >>> The mask used inside this macro was assuming Buffer_Size1's[BS1's] >>> width to be 14 bits, >>> it is actually of 13 bits, Modified masks used in >>> IDMAC_SET_BUFFER1_SIZE such that >>> they use only 13 bits instead of current 14. >>> >>> Signed-off-by: Shashidhar Hiremath <shashidharh@vayavyalabs.com> > > Yes, looks correct to me too (for some reason I didn't get the original mail). > > Acked-by: Will Newton <will.newton@imgtec.com> Pushed to mmc-next for 3.1, thanks. (I didn't get the original mail either; it looks like the mailing lists rejected it for some reason.) - Chris. -- Chris Ball <cjb@laptop.org> <http://printf.net/> One Laptop Per Child ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-07-29 12:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1311851023-3563-1-git-send-email-shashidharh@vayavyalabs.com>
2011-07-28 11:17 ` [PATCH 1/1] mmc: Fixed bug in IDMAC_SET_BUFFER1_SIZE Macro in dw_mmc.c James Hogan
2011-07-29 2:17 ` Jaehoon Chung
2011-07-29 6:51 ` Jaehoon Chung
2011-07-29 10:07 ` Will Newton
2011-07-29 12:53 ` Chris Ball
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox