* [PATCH] bnx2fc: use kthread_create_on_node
@ 2011-07-29 7:06 Eric Dumazet
2011-07-29 19:22 ` Bhanu Prakash Gollapudi
0 siblings, 1 reply; 2+ messages in thread
From: Eric Dumazet @ 2011-07-29 7:06 UTC (permalink / raw)
To: Bhanu Prakash Gollapudi; +Cc: James E.J. Bottomley, linux-scsi, linux-kernel
Since bnx2fc_percpu_thread_create() creates percpu kthread, it makes
sense to use kthread_create_on_node() to get proper NUMA affinity for
kthread stack.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
CC: "James E.J. Bottomley" <JBottomley@parallels.com>
---
drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
index a97aff3..9843434 100644
--- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
+++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
@@ -2161,9 +2161,9 @@ static void bnx2fc_percpu_thread_create(unsigned int cpu)
p = &per_cpu(bnx2fc_percpu, cpu);
- thread = kthread_create(bnx2fc_percpu_io_thread,
- (void *)p,
- "bnx2fc_thread/%d", cpu);
+ thread = kthread_create_on_node(bnx2fc_percpu_io_thread,
+ (void *)p, cpu_to_node(cpu),
+ "bnx2fc_thread/%d", cpu);
/* bind thread to the cpu */
if (likely(!IS_ERR(p->iothread))) {
kthread_bind(thread, cpu);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] bnx2fc: use kthread_create_on_node
2011-07-29 7:06 [PATCH] bnx2fc: use kthread_create_on_node Eric Dumazet
@ 2011-07-29 19:22 ` Bhanu Prakash Gollapudi
0 siblings, 0 replies; 2+ messages in thread
From: Bhanu Prakash Gollapudi @ 2011-07-29 19:22 UTC (permalink / raw)
To: Eric Dumazet
Cc: James E.J. Bottomley, linux-scsi@vger.kernel.org, linux-kernel
On 7/29/2011 12:06 AM, Eric Dumazet wrote:
> Since bnx2fc_percpu_thread_create() creates percpu kthread, it makes
> sense to use kthread_create_on_node() to get proper NUMA affinity for
> kthread stack.
>
> Signed-off-by: Eric Dumazet<eric.dumazet@gmail.com>
> CC: "James E.J. Bottomley"<JBottomley@parallels.com>
Thanks Eric.
Acked-by: Bhanu Prakash Gollapudi <bprakash@broadcom.com>
> ---
> drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> index a97aff3..9843434 100644
> --- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> +++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> @@ -2161,9 +2161,9 @@ static void bnx2fc_percpu_thread_create(unsigned int cpu)
>
> p =&per_cpu(bnx2fc_percpu, cpu);
>
> - thread = kthread_create(bnx2fc_percpu_io_thread,
> - (void *)p,
> - "bnx2fc_thread/%d", cpu);
> + thread = kthread_create_on_node(bnx2fc_percpu_io_thread,
> + (void *)p, cpu_to_node(cpu),
> + "bnx2fc_thread/%d", cpu);
> /* bind thread to the cpu */
> if (likely(!IS_ERR(p->iothread))) {
> kthread_bind(thread, cpu);
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-07-29 19:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-29 7:06 [PATCH] bnx2fc: use kthread_create_on_node Eric Dumazet
2011-07-29 19:22 ` Bhanu Prakash Gollapudi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox