Re: [PATCH] perf: add --symfs option to perf annotate

[David Ahern <daahern@cisco.com>]

On 07/29/2011 05:20 PM, Stephane Eranian wrote:
> 
> If you have --symfs in perf report, then you also need it
> for perf annotate. This allows off-box assembly level analysis
> of perf.data samples.
> 
> This patch complements:
> 
> commit ec5761eab318e50e69fcf8e63e9edaef5949c067
> Author: David Ahern <daahern@cisco.com>
> Date:   Thu Dec 9 13:27:07 2010 -0700
> 
>     perf symbols: Add symfs option for off-box analysis using specified tree
> 
> Signed-off-by: Stephane Eranian <eranian@google.com>
> ---
> 
> diff --git a/tools/perf/Documentation/perf-annotate.txt b/tools/perf/Documentation/perf-annotate.txt
> index 85c5f02..15919dd 100644
> --- a/tools/perf/Documentation/perf-annotate.txt
> +++ b/tools/perf/Documentation/perf-annotate.txt
> @@ -72,6 +72,9 @@ OPTIONS
>  	CPUs are specified with -: 0-2. Default is to report samples on all
>  	CPUs.
>  
> +--symfs=<directory>::
> +        Look for files with symbols relative to this directory.
> +
>  SEE ALSO
>  --------
>  linkperf:perf-record[1], linkperf:perf-report[1]
> diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c
> index 555aefd..1605fbe 100644
> --- a/tools/perf/builtin-annotate.c
> +++ b/tools/perf/builtin-annotate.c
> @@ -267,6 +267,8 @@ static const struct option options[] = {
>  	OPT_BOOLEAN('P', "full-paths", &full_paths,
>  		    "Don't shorten the displayed pathnames"),
>  	OPT_STRING('c', "cpu", &cpu_list, "cpu", "list of cpus to profile"),
> +	OPT_STRING(0, "symfs", &symbol_conf.symfs, "directory",
> +		    "Look for files with symbols relative to this directory"),
>  	OPT_END()
>  };
>  

Acked-by: David Ahern <daahern@cisco.com>

Nice to see others making use of that option.

David