Re: v3.0: Weird kernel log message when resuming avout NMI received

Peter Zijlstra
2011-08-01T12:07:58Z

On Mon, 2011-08-01 at 15:21 +0400, Cyrill Gorcunov wrote:
> > mutex_lock(&swhash->hlist_mutex);
> > - if (swhash->hlist_refcount > 0) {
> > + if (swhash->hlist_refcount > 0 && !swhash->swevent_hlist) {
>
> Should not there be rcu_dereference(swhash->swevent_hlist)?

swhash->hlist_mutex is the modifier lock for that rcu use and should
thus serialize things sufficiently.