* [PATCH]blk-throttle: correctly determine sync bio
@ 2011-08-01 7:39 Shaohua Li
2011-08-01 8:31 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Shaohua Li @ 2011-08-01 7:39 UTC (permalink / raw)
To: Jens Axboe; +Cc: lkml, Vivek Goyal
read request is always sync. Using rw_is_sync() to determine
if a bio is sync.
Signed-off-by: Shaohua Li <shaohua.li@intel.com>
diff --git a/block/blk-throttle.c b/block/blk-throttle.c
index f6a7941..a19f58c 100644
--- a/block/blk-throttle.c
+++ b/block/blk-throttle.c
@@ -746,7 +746,7 @@ static bool tg_may_dispatch(struct throtl_data *td, struct throtl_grp *tg,
static void throtl_charge_bio(struct throtl_grp *tg, struct bio *bio)
{
bool rw = bio_data_dir(bio);
- bool sync = bio->bi_rw & REQ_SYNC;
+ bool sync = rw_is_sync(bio->bi_rw);
/* Charge the bio to the group */
tg->bytes_disp[rw] += bio->bi_size;
@@ -1150,7 +1150,7 @@ int blk_throtl_bio(struct request_queue *q, struct bio **biop)
if (tg_no_rule_group(tg, rw)) {
blkiocg_update_dispatch_stats(&tg->blkg, bio->bi_size,
- rw, bio->bi_rw & REQ_SYNC);
+ rw, rw_is_sync(bio->bi_rw));
rcu_read_unlock();
return 0;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH]blk-throttle: correctly determine sync bio
2011-08-01 7:39 [PATCH]blk-throttle: correctly determine sync bio Shaohua Li
@ 2011-08-01 8:31 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2011-08-01 8:31 UTC (permalink / raw)
To: Shaohua Li; +Cc: lkml, Vivek Goyal
On 2011-08-01 09:39, Shaohua Li wrote:
> read request is always sync. Using rw_is_sync() to determine
> if a bio is sync.
Thanks, good catch. Applied.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-01 8:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-01 7:39 [PATCH]blk-throttle: correctly determine sync bio Shaohua Li
2011-08-01 8:31 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox