From: Michal Marek <mmarek@suse.cz>
To: Peter Foley <pefoley2@verizon.net>
Cc: Arnaud Lacombe <lacombar@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Kbuild Mailing List <linux-kbuild@vger.kernel.org>,
rdunlap@xenotime.net
Subject: Re: [PATCH RFC] kconfig.h fix extraneous dependencies
Date: Mon, 01 Aug 2011 11:24:15 +0200 [thread overview]
Message-ID: <4E3670BF.6000709@suse.cz> (raw)
In-Reply-To: <alpine.LNX.2.00.1107312055360.20006@linux>
On 1.8.2011 03:16, Peter Foley wrote:
> On Sun, 31 Jul 2011, Arnaud Lacombe wrote:
>> On Sun, Jul 31, 2011 at 8:36 PM, Peter Foley<pefoley2@verizon.net> wrote:
>>> The introduction of kconfig.h caused fixdep to create three extraneous
>>> dependencies.
>>> include/config/.h
>>> include/config/h.h
>>> include/config/foo.h
>>>
>>> Remove them by eliminating instances of CONFIG_
>>>
>> this seems ugly to me... I would rather try to fix fixdep, no ?
>>
>> - Arnaud
>
> I'd be the first to admit that this patch is a ugly hack.
> However, judging by the comments in fixdep.c this is expected behavior.
And it's also harmless, the source contains thousands of false matches:
$ git grep '_CONFIG_' | wc -l
7989
e.g anything that includes include/linux/acpi.h gets a false dependency
on include/config/support.h because of
include/linux/acpi.h:#define OSC_EXT_PCI_CONFIG_SUPPORT 1
but it doesn't matter.
> I'm also afraid that changing fixdep to ignore comments would slow down
> the whole build for the sake of one file which IMHO dosen't seem to be a
> worthwhile tradeoff.
I would take a patch that makes fixdep ignore include/linux/kconfig.h,
like it ignores include/generated/kconfig.h. Anything more advanced
isn't worth the effort, IMO.
Michal
next prev parent reply other threads:[~2011-08-01 9:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 0:36 [PATCH RFC] kconfig.h fix extraneous dependencies Peter Foley
2011-08-01 0:53 ` Arnaud Lacombe
2011-08-01 1:16 ` Peter Foley
2011-08-01 9:24 ` Michal Marek [this message]
2011-08-01 13:51 ` [PATCH v2] " Peter Foley
2011-09-09 9:46 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E3670BF.6000709@suse.cz \
--to=mmarek@suse.cz \
--cc=lacombar@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pefoley2@verizon.net \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).