Re: [PATCH 1/8] staging: vme_user: change kmalloc+memset to kzalloc

[Martyn Welch <martyn.welch@ge.com>]

On 01/08/11 11:20, Manohar Vanga wrote:
> Signed-off-by: Manohar Vanga <manohar.vanga@cern.ch>

Acked-by: Martyn Welch <martyn.welch@ge.com>

> ---
>  drivers/staging/vme/devices/vme_user.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c
> index 91d2cc7..3cbeb2a 100644
> --- a/drivers/staging/vme/devices/vme_user.c
> +++ b/drivers/staging/vme/devices/vme_user.c
> @@ -651,7 +651,7 @@ static int __init vme_user_init(void)
>  
>  
>  	/* Dynamically create the bind table based on module parameters */
> -	ids = kmalloc(sizeof(struct vme_device_id) * (bus_num + 1), GFP_KERNEL);
> +	ids = kzalloc(sizeof(struct vme_device_id) * (bus_num + 1), GFP_KERNEL);
>  	if (ids == NULL) {
>  		printk(KERN_ERR "%s: Unable to allocate ID table\n",
>  			driver_name);
> @@ -659,8 +659,6 @@ static int __init vme_user_init(void)
>  		goto err_id;
>  	}
>  
> -	memset(ids, 0, (sizeof(struct vme_device_id) * (bus_num + 1)));
> -
>  	for (i = 0; i < bus_num; i++) {
>  		ids[i].bus = bus[i];
>  		/*


-- 
Martyn Welch (Principal Software Engineer) | Registered in England and
GE Intelligent Platforms                   | Wales (3828642) at 100
T +44(0)127322748                          | Barbirolli Square, Manchester,
E martyn.welch@ge.com                      | M2 3AB  VAT:GB 927559189