Re: [PATCH] input: misc: Add support for pm8xxx based vibrator driver

Wanlong Gao
2011-08-02T05:32:17Z

On 08/02/2011 01:26 PM, Dmitry Torokhov wrote:
> On Tue, Aug 02, 2011 at 01:18:46PM +0800, Wanlong Gao wrote:
>> On 08/02/2011 01:11 PM, Dmitry Torokhov wrote:
>>> On Tue, Aug 02, 2011 at 12:42:43PM +0800, Wanlong Gao wrote:
>>>> On 08/02/2011 12:13 PM, Anirudh Ghayal wrote:
>>>>> +/*
>>>>> + * struct pm8xxx_vib - structure to hold vibrator data
>>>>> + * @vib_input_dev: input device supporting force feedback
>>>>> + * @vwork: work structure to set the vibration parameters
>>>> Anirudh, It's should be @work?
>>>
>>> Looks like it, I can fix it up locally, no need to resubmit.
>>>
>>> BTW, please do not hesitate to add your Reviewed-by or Acked-by if you
>>> are mostly satisfied with the patch (sans a few minor issues that you
>>> should point out). I can't guarantee that I will always add your tags
>>> (depends on when I commit the patch to my one of my public branches) but
>>> I will try to do so.
>>>
>>> Thanks.
>>>
>> Sure, I see, thanks Dmitry.
>>
>
> So was this reviewed-by? ;)
Sure.
Reviewed-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>

Sorry. ;)

Thanks
Best Regards
Wanlong Gao