From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Anirudh Ghayal <aghayal@codeaurora.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
Amy Maloche <amaloche@codeaurora.org>
Subject: Re: [PATCH] input: misc: Add support for pm8xxx based vibrator driver
Date: Tue, 02 Aug 2011 13:18:46 +0800 [thread overview]
Message-ID: <4E3788B6.4020104@cn.fujitsu.com> (raw)
In-Reply-To: <20110802051156.GA7372@core.coreip.homeip.net>
On 08/02/2011 01:11 PM, Dmitry Torokhov wrote:
> On Tue, Aug 02, 2011 at 12:42:43PM +0800, Wanlong Gao wrote:
>> On 08/02/2011 12:13 PM, Anirudh Ghayal wrote:
>>> +/*
>>> + * struct pm8xxx_vib - structure to hold vibrator data
>>> + * @vib_input_dev: input device supporting force feedback
>>> + * @vwork: work structure to set the vibration parameters
>> Anirudh, It's should be @work?
>
> Looks like it, I can fix it up locally, no need to resubmit.
>
> BTW, please do not hesitate to add your Reviewed-by or Acked-by if you
> are mostly satisfied with the patch (sans a few minor issues that you
> should point out). I can't guarantee that I will always add your tags
> (depends on when I commit the patch to my one of my public branches) but
> I will try to do so.
>
> Thanks.
>
Sure, I see, thanks Dmitry.
Wanlong Gao
next prev parent reply other threads:[~2011-08-02 5:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 4:13 [PATCH] input: misc: Add support for pm8xxx based vibrator driver Anirudh Ghayal
2011-08-02 4:42 ` Wanlong Gao
2011-08-02 5:11 ` Dmitry Torokhov
2011-08-02 5:18 ` Wanlong Gao [this message]
2011-08-02 5:26 ` Dmitry Torokhov
2011-08-02 5:31 ` Wanlong Gao
[not found] ` <CAM=Q2cvzsZO4dc6Ot_aYJyLW27TErgySdXRcHr1UDb5ua1uHAg@mail.gmail.com>
2011-08-02 6:27 ` Anirudh Ghayal
2011-08-02 6:41 ` Dmitry Torokhov
2011-08-02 9:00 ` Anirudh Ghayal
2011-08-03 6:02 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E3788B6.4020104@cn.fujitsu.com \
--to=gaowanlong@cn.fujitsu.com \
--cc=aghayal@codeaurora.org \
--cc=amaloche@codeaurora.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox