From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752900Ab1HBFTv (ORCPT ); Tue, 2 Aug 2011 01:19:51 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:53033 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1750773Ab1HBFTt (ORCPT ); Tue, 2 Aug 2011 01:19:49 -0400 Message-ID: <4E3788B6.4020104@cn.fujitsu.com> Date: Tue, 02 Aug 2011 13:18:46 +0800 From: Wanlong Gao Reply-To: gaowanlong@cn.fujitsu.com Organization: FNST User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110322 Red Hat/3.1.9-3.el6_0 Thunderbird/3.1.9 MIME-Version: 1.0 To: Dmitry Torokhov CC: Anirudh Ghayal , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Amy Maloche Subject: Re: [PATCH] input: misc: Add support for pm8xxx based vibrator driver References: <1312258397-11039-1-git-send-email-aghayal@codeaurora.org> <4E378043.3080801@cn.fujitsu.com> <20110802051156.GA7372@core.coreip.homeip.net> In-Reply-To: <20110802051156.GA7372@core.coreip.homeip.net> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.1FP4|July 25, 2010) at 2011-08-02 13:18:47, Serialize by Router on mailserver/fnst(Release 8.5.1FP4|July 25, 2010) at 2011-08-02 13:18:48, Serialize complete at 2011-08-02 13:18:48 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/02/2011 01:11 PM, Dmitry Torokhov wrote: > On Tue, Aug 02, 2011 at 12:42:43PM +0800, Wanlong Gao wrote: >> On 08/02/2011 12:13 PM, Anirudh Ghayal wrote: >>> +/* >>> + * struct pm8xxx_vib - structure to hold vibrator data >>> + * @vib_input_dev: input device supporting force feedback >>> + * @vwork: work structure to set the vibration parameters >> Anirudh, It's should be @work? > > Looks like it, I can fix it up locally, no need to resubmit. > > BTW, please do not hesitate to add your Reviewed-by or Acked-by if you > are mostly satisfied with the patch (sans a few minor issues that you > should point out). I can't guarantee that I will always add your tags > (depends on when I commit the patch to my one of my public branches) but > I will try to do so. > > Thanks. > Sure, I see, thanks Dmitry. Wanlong Gao