From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: "Leonid V. Fedorenchik" <leonidsbox@gmail.com>
Cc: Joe Perches <joe@perches.com>,
gregkh@suse.de, devel@driverdev.osuosl.org, arnd@arndb.de,
linux-kernel@vger.kernel.org, Palash.Bandyopadhyay@conexant.com,
ruslan@rpisarev.org.ua, Revent82@gmail.com
Subject: Re: [PATCH] Staging: cx25821: fix coding style issues
Date: Tue, 02 Aug 2011 08:42:24 -0300 [thread overview]
Message-ID: <4E37E2A0.9090109@redhat.com> (raw)
In-Reply-To: <20110802171856.044cd78d@inspire>
Em 02-08-2011 06:18, Leonid V. Fedorenchik escreveu:
> Thanks for the review. I sent v2. I have a question, however...
>
> On Mon, 01 Aug 2011 09:14:22 -0700
> Joe Perches <joe@perches.com> wrote:
>
>> On Mon, 2011-08-01 at 17:33 +0800, Leonid V. Fedorenchik wrote:
>>> Fix too long lines in cx25821-audio.h and cx25821-core.c
>> []
>>> diff --git a/drivers/staging/cx25821/cx25821-core.c b/drivers/staging/cx25821/cx25821-core.c
>> []
>>> @@ -972,8 +972,8 @@ static int cx25821_dev_setup(struct cx25821_dev *dev)
>>> dev->lmmio = ioremap(dev->base_io_addr, pci_resource_len(dev->pci, 0));
>>>
>>> if (!dev->lmmio) {
>>> - CX25821_ERR
>>> - ("ioremap failed, maybe increasing __VMALLOC_RESERVE in page.h\n");
>>> + CX25821_ERR("ioremap failed, maybe increasing __VMALLOC_RESERVE"
>>> + " in page.h\n");
>>
>> Please do not split formats.
>
> What is the reason to not split formats?
> I can see that in Documentation/CodingStyle in Chapter 2 it is OK to split
> formats if it is not making readability worse.
> So, is it for the sake of readability or is it new coding style rule for the
> kernel that is not in documentation yet or something else or am I misunderstood
> something?
Breaking long printk lines break things like:
git grep "__VMALLOC_RESERVE in page.h"
Cheers,
Mauro
prev parent reply other threads:[~2011-08-02 11:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 9:33 [PATCH] Staging: cx25821: fix coding style issues Leonid V. Fedorenchik
2011-08-01 16:14 ` Joe Perches
2011-08-02 9:18 ` Leonid V. Fedorenchik
2011-08-02 11:42 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E37E2A0.9090109@redhat.com \
--to=mchehab@redhat.com \
--cc=Palash.Bandyopadhyay@conexant.com \
--cc=Revent82@gmail.com \
--cc=arnd@arndb.de \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=joe@perches.com \
--cc=leonidsbox@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ruslan@rpisarev.org.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox